Internal server error occurs during data source creation

Bug #1277497 reported by Yaroslav Lobankov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Low
Matthew Farrellee

Bug Description

Send request:

POST http://<savanna host>:<savanna port>/v1.1/<tenant ID>/data-sources
{
  "url": "swift://savanna-container.savanna/input",
  "type": "swift",
  "name": "savanna-data-source"
}

EXPECTED RESULT: There should be validation error with error code 400 and description that field "credentials" is required

ACTUAL RESULT:
{
    "error_name": "INTERNAL_SERVER_ERROR",
    "error_message": "Error occurred during validation",
    "error_code": 500
}

summary: - Internal server error occures during data source creation
+ Internal server error occurs during data source creation
Changed in savanna:
milestone: none → icehouse-3
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Matthew Farrellee (mattf) wrote :

what version of savanna is this confirmed for?

Revision history for this message
Yaroslav Lobankov (ylobankov) wrote :

Savanna is from master branch.

Revision history for this message
Yaroslav Lobankov (ylobankov) wrote :

Also there is the following trace:

2014-02-10 12:28:13.928 11321 ERROR savanna.utils.api [-] Request aborted with status code 500 and message 'Error occurred during validation'
2014-02-10 12:28:13.928 11321 ERROR savanna.utils.api [-] Traceback (most recent call last):
  File "/home/ylobankov/Savanna/master/savanna/savanna/service/validation.py", line 37, in handler
    validator(**kwargs)
  File "/home/ylobankov/Savanna/master/savanna/savanna/service/validations/edp/data_source.py", line 55, in check_data_source_create
    _check_swift_data_source_create(data)
  File "/home/ylobankov/Savanna/master/savanna/savanna/service/validations/edp/data_source.py", line 62, in _check_swift_data_source_create
    if not ("user" in data["credentials"]
KeyError: 'credentials'

Changed in savanna:
assignee: nobody → Matthew Farrellee (mattf)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to savanna (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72933

Changed in savanna:
status: Confirmed → In Progress
Changed in savanna:
milestone: icehouse-3 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to savanna (master)

Reviewed: https://review.openstack.org/72933
Committed: https://git.openstack.org/cgit/openstack/savanna/commit/?id=4b453e15677b869b707fc01e8e4fbe41f6424b67
Submitter: Jenkins
Branch: master

commit 4b453e15677b869b707fc01e8e4fbe41f6424b67
Author: Matthew Farrellee <email address hidden>
Date: Wed Feb 12 07:31:44 2014 -0500

    Fix swift data source credential validation

    The validation for swift data source credentials assumed that only the
    elements within the credentials were missing. If the credentials
    element itself was missing an internal error would be triggered.

    Change-Id: I1c5d9673ae383eb8154508be01ceb67877b6e0cb
    Closes-bug: #1277497

Changed in savanna:
status: In Progress → Fix Committed
Revision history for this message
Sergey Lukjanov (slukjanov) wrote :

Fixed in i3

Changed in sahara:
milestone: next → icehouse-3
Thierry Carrez (ttx)
Changed in sahara:
milestone: icehouse-3 → 2014.1
Changed in sahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.