Rsyslog upstart script does not include /etc/default/rsyslog on start

Bug #1281485 reported by Bogdan Dobrelya
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Bogdan Dobrelya

Bug Description

To reproduce (Ubuntu):
grep "c.*5" /etc/default/rsyslog; ps auxefw | grep rsyslog | grep -v grep
SYSLOGD_OPTIONS="-c 5 -x"
root 14694 0.0 0.1 276260 1644 ? Sl 09:08 0:00 rsyslogd UPSTART_INSTANCE= UPSTART_JOB=rsyslog TERM=linux
PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/bin PWD=/

And "-c 5 -x" is ignored by rsyslog upstart script. That causes rsyslog is being running in compatibility mode and puts WARNINGS in the log.

Centos is OK, tho.
grep "c.*5" /etc/sysconfig/rsyslog; ps auxefw | grep rsyslog | grep -v grep
SYSLOGD_OPTIONS="-c 5 -x"
root 8438 0.0 0.1 411048 1680 ? Sl Feb17 0:26 /sbin/rsyslogd -i /var/run/syslogd.pid -c 5 -x TERM=screen PATH=/sbin:/usr/sbin:/bin:/usr/bin PWD=/ LANG=en_US.UTF-8 SHLVL=2 _=/sbin/rsyslogd

Changed in fuel:
milestone: none → 5.0
Changed in fuel:
assignee: nobody → Fuel OSCI Team (fuel-osci)
Roman Vyalov (r0mikiam)
Changed in fuel:
assignee: Fuel OSCI Team (fuel-osci) → Vitaly Parakhin (vparakhin)
Revision history for this message
Vitaly Parakhin (vparakhin) wrote :

Could you please post the contents of /etc/init/rsyslog.conf ?

Changed in fuel:
status: Triaged → Incomplete
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

description "system logging daemon"

start on filesystem
stop on runlevel [06]

expect fork
respawn

pre-start script
    /lib/init/apparmor-profile-load usr.sbin.rsyslogd
end script

script
    . /etc/default/rsyslog
    exec rsyslogd $RSYSLOGD_OPTIONS
end script

Changed in fuel:
status: Incomplete → In Progress
Revision history for this message
Vitaly Parakhin (vparakhin) wrote :

Sorry, we cannot confirm this bug, as it seems that Ubuntu 12.04 honors /etc/default/rsyslog as well, see transcript below:

ubuntu@ubuntu-deb-test:~$ cat /etc/issue
Ubuntu 12.04 LTS \n \l

ubuntu@ubuntu-deb-test:~$ grep RSYSLOG /etc/default/rsyslog
RSYSLOGD_OPTIONS="-c5 -x -r"
ubuntu@ubuntu-deb-test:~$ ps auwwfx |grep rsyslog |grep -v grep
syslog 4978 0.0 0.1 183928 1476 ? Sl 07:56 0:00 rsyslogd -c5 -x -r

< modify /etc/default/rsyslog >

ubuntu@ubuntu-deb-test:~$ grep RSYSLOG /etc/default/rsyslog
RSYSLOGD_OPTIONS="-c5"
ubuntu@ubuntu-deb-test:~$ sudo stop rsyslog
rsyslog stop/waiting
ubuntu@ubuntu-deb-test:~$ sudo start rsyslog
rsyslog start/running, process 5274
ubuntu@ubuntu-deb-test:~$ ps auwwfx |grep rsyslog |grep -v grep
syslog 5274 0.0 0.1 118392 1476 ? Sl 07:59 0:00 rsyslogd -c5

Changed in fuel:
status: In Progress → Invalid
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

you are right, this is a configuration issue

Changed in fuel:
assignee: Vitaly Parakhin (vparakhin) → Bogdan Dobrelya (bogdando)
status: Invalid → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86924

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/86924
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3c9ccb2b84f8ff22a19d13610d9aaf88eb88c764
Submitter: Jenkins
Branch: master

commit 3c9ccb2b84f8ff22a19d13610d9aaf88eb88c764
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Apr 11 17:59:39 2014 +0300

    Fix rsyslog defaults typo for ubuntu

    CI retest
    Closes-bug: #1281485

    Change-Id: Ib0e78c15aeaf16fb1f8e7e8abc354f153b6d970b
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.