Cinder

python 3 only has "self", the "im_self" should be replace by "__self_"

Bug #1282514 reported by Shuangtai Tian on 2014-02-20

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Cinder	Fix Released	Wishlist	Shuangtai Tian	Cinder 2014.1 "icehouse"
Ironic	Fix Released	Wishlist	Fengqian	Ironic 2014.1 "icehouse"
OpenStack Compute (nova)	Won't Fix	Wishlist	Xurong Yang
oslo-incubator	Fix Released	Medium	David Stanek	oslo-incubator juno-2 "j2"
tuskar	Fix Released	Medium	Fengqian

Bug Description

for code compatible with Python 3, we should use the "__self__" instead of "im_self".
for example :
cinder/volume/flows/common.py

def make_pretty_name(method):
    """Makes a pretty name for a function/method."""
    meth_pieces = [method.__name__]
    # If its an instance method attempt to tack on the class name
    if hasattr(method, 'im_self') and method.im_self is not None:
        try:
            meth_pieces.insert(0, method.im_self.__class__.__name__)
        except AttributeError:
            pass
    return ".".join(meth_pieces)

For reference here(thanks Alex for adding this):
"Changed in version 2.6: For Python 3 forward-compatibility, im_func is also available as __func__, and im_self as __self__."
http://docs.python.org/2/reference/datamodel.html

See original description

Shuangtai Tian (shuangtai-tian) on 2014-02-20

Changed in cinder:
assignee:	nobody → Shuangtai Tian (shuangtai-tian)

OpenStack Infra (hudson-openstack) on 2014-02-20

Changed in cinder:
status:	New → In Progress

Revision history for this message

Alex Meade (alex-meade) wrote on 2014-02-25:

For reference here:

"Changed in version 2.6: For Python 3 forward-compatibility, im_func is also available as __func__, and im_self as __self__."
http://docs.python.org/2/reference/datamodel.html

Shuangtai Tian (shuangtai-tian) on 2014-02-26

description:

updated

Fengqian (fengqian-gao) on 2014-02-26

Changed in ironic:
assignee:	nobody → Fengqian (fengqian-gao)
status:	New → In Progress
Changed in tuskar:
assignee:	nobody → Fengqian (fengqian-gao)

Shuangtai Tian (shuangtai-tian) on 2014-02-26

Changed in tuskar:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-26: Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76517

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-26: Fix proposed to tuskar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76522

Jiří Stránský (jistr) on 2014-02-26

Changed in tuskar:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-26: Fix merged to tuskar (master)

Reviewed: https://review.openstack.org/76522
Committed: https://git.openstack.org/cgit/openstack/tuskar/commit/?id=c07b38f806687a99ff60b60145e571f8faac64a4
Submitter: Jenkins
Branch: master

commit c07b38f806687a99ff60b60145e571f8faac64a4
Author: Fengqian Gao <email address hidden>
Date: Wed Feb 26 20:34:19 2014 +0800

Python 3: replace "im_self" by "__self__"

    The Python 3 removed the "im_self" attribute. This patch
    replaces "im_self" by "__self__" attribute.
    Partial-Bug: #1282514

Change-Id: I53567c856b81c9b2fceaf131ee918dd850ac4f03

Xurong Yang (idopra) on 2014-02-27

Changed in oslo:
assignee:	nobody → Xurong Yang (idopra)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-27: Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76725

Xurong Yang (idopra) on 2014-02-27

Changed in nova:
assignee:	nobody → Xurong Yang (idopra)
status:	New → In Progress

Revision history for this message

Joe Gordon (jogo) wrote on 2014-02-27:

nova isn't python 3 compatible yet primarily due to incompatible dependencies, until we have a roadmap and a timeline to fix those I see little value in making nova itself python 3 compatible. It will just cause unnecessary churn that is hard to gate on.

Changed in nova:
status:	In Progress → Invalid

Revision history for this message

John Griffith (john-griffith) wrote on 2014-02-27:

So to Joe's point if that's the case and there isn't an agreement on doing these conversions across the board there's no point in doing it in any of the projects IMO. It's a minor patch so I don't have a problem approving it but I think as a whole we need to get a handle on our plans for PY3.3 and come to an agreement and maybe a strategy rather than the continued one off patches every day.

Changed in cinder:
importance:	Undecided → Wishlist

Fengqian (fengqian-gao) on 2014-02-28

Changed in tuskar:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-28: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77036

Changed in nova:
status:	Invalid → In Progress

Shuangtai Tian (shuangtai-tian) on 2014-02-28

Changed in nova:
importance:	Undecided → Wishlist

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-28: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/74946
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=14903b4ca7d625b8e93fe431f854263bbe26e4bc
Submitter: Jenkins
Branch: master

commit 14903b4ca7d625b8e93fe431f854263bbe26e4bc
Author: Shuangtai Tian <email address hidden>
Date: Thu Feb 20 14:43:11 2014 +0800

Python 3: replace "im_self" by "__self__"

The Python 3 removed the "im_self" attribute and only supports the
"__self__". This patch replaces "im_self" by "__self__" attribute.

Closes-Bug: #1282514
Change-Id: Ib017fff4b720a5dd7ee27fd01b36a531d9b6ca9c

Changed in cinder:
status:	In Progress → Fix Committed

Roman Podoliaka (rpodolyaka) on 2014-02-28

Changed in tuskar:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-03-04: Fix merged to ironic (master)

#10

Reviewed: https://review.openstack.org/76517
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3db0e35f0b669192f4d91671217b8cf5fdab4a0a
Submitter: Jenkins
Branch: master

commit 3db0e35f0b669192f4d91671217b8cf5fdab4a0a
Author: Fengqian Gao <email address hidden>
Date: Wed Feb 26 20:24:13 2014 +0800

Python 3: replace "im_self" by "__self__"

The Python 3 removed the "im_self" attribute. This patch
replaces "im_self" by "__self__" attribute.

Partial-Bug: #1282514

Change-Id: Icd255eec61f225e2dc66a7efd51551f4b78ac258

Thierry Carrez (ttx) on 2014-03-05

Changed in cinder:
milestone:	none → icehouse-3
status:	Fix Committed → Fix Released

Doug Hellmann (doug-hellmann) on 2014-03-10

Changed in oslo:
importance:	Undecided → Medium

aeva black (tenbrae) on 2014-03-26

Changed in ironic:
status:	In Progress → Fix Committed
importance:	Undecided → Wishlist

Thierry Carrez (ttx) on 2014-04-01

Changed in ironic:
milestone:	none → icehouse-rc1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2014-04-17

Changed in cinder:
milestone:	icehouse-3 → 2014.1

Thierry Carrez (ttx) on 2014-04-17

Changed in ironic:
milestone:	icehouse-rc1 → 2014.1

OpenStack Infra (hudson-openstack) on 2014-06-30

Changed in oslo:
assignee:	Xurong Yang (idopra) → David Stanek (dstanek)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-02: Fix merged to oslo-incubator (master)

#11

Reviewed: https://review.openstack.org/76725
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=011fc276eaacf371c35f890930b9229ca779b443
Submitter: Jenkins
Branch: master

commit 011fc276eaacf371c35f890930b9229ca779b443
Author: yangxurong <email address hidden>
Date: Thu Feb 27 09:33:45 2014 +0800

Python 3: replace "im_self" by "__self__"

    The Python 3 removed the "im_self" attribute. This patch
    replaces "im_self" by "__self__" attribute.
    Original description http://docs.python.org/2/reference/datamodel.html

Change-Id: I0e66553ccebfcae750693177354723f332637cf5
Partial-Bug: #1282514

Doug Hellmann (doug-hellmann) on 2014-07-03

Changed in oslo:
status:	In Progress → Fix Committed

Russell Bryant (russellb) on 2014-07-23

Changed in oslo:
milestone:	none → juno-2
status:	Fix Committed → Fix Released

Revision history for this message

Sean Dague (sdague) wrote on 2014-09-15:

#12

The only place this still exists in nova is code that will be removed when python 2.6 is dropped.

Changed in nova:
status:	In Progress → Won't Fix

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Cinder

python 3 only has "__self__", the "im_self" should be replace by "__self_"

Bug Description

Other bug subscribers

Remote bug watches

python 3 only has "self", the "im_self" should be replace by "__self_"