oslo-incubator

oslo-incubator py33 gate failing on pycadf

Bug #1284379 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Critical
Doug Hellmann
oslo-incubator 2014.1 "icehouse"
pycadf
Invalid
Critical
gordon chung

Bug Description

oslo-incubator isn't python 3 compatible, but we gate on it anyway https://review.openstack.org/#/c/74097/

2014-02-24 22:06:00.332 | Downloading/unpacking eventlet>=0.13.0 (from oslo.messaging>=1.3.0a4->pycadf>=0.1.9->-r /home/jenkins/workspace/gate-oslo-incubator-python33/requirements-py3.txt (line 14))

requirements-py3 use pycadf which needs oslo.messaging which uses eventlet.

https://github.com/openstack/pycadf/commit/fa802a753d00b4e61eebbc7360caecffba3d7852

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76047

Changed in oslo:
assignee: nobody → Doug Hellmann (doug-hellmann)
status: New → In Progress
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This commit in pycadf introduces oslo.messaging: https://github.com/openstack/pycadf/commit/fa802a753d00b4e61eebbc7360caecffba3d7852

We should look carefully at the dependency graph we have with pycadf and the other oslo libraries to ensure we're not introducing a cycle by having pycadf depend on oslo.messaging.

Changed in oslo:
importance: Undecided → Critical
milestone: none → icehouse-3
summary: - oslo-incubator isn't python3 compatible
+ oslo-incubator py33 gate failing on pycadf
Changed in pycadf:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → gordon chung (chungg)
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This change to set up the py33 gate merged today: https://review.openstack.org/#/c/74097/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/76047
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=24ce1e06b948be08123a23525ead1edfa8f96dab
Submitter: Jenkins
Branch: master

commit 24ce1e06b948be08123a23525ead1edfa8f96dab
Author: Doug Hellmann <email address hidden>
Date: Mon Feb 24 16:02:10 2014 -0800

    Remove pycadf from the python 3 requirements

    PyCADF depends on oslo.messaging, which does not support python 3,
    yet.

    Change-Id: Ic376b4101d59f8629d0a0a9d9bdd8bc785669f16
    Partial-bug: #1284379

Doug Hellmann (doug-hellmann)
Changed in oslo:
status: In Progress → Fix Committed
Revision history for this message
gordon chung (chungg) wrote :

thanks for the headsup Doug.

pycadf is only used by audit.py middleware in oslo-incubator which isn't used by either oslo.messaging and pycadf so i believe we should be ok regarding cyclic dependencies. please let me know if i missed anything.

is the critical priority still relevant? if so this is heavily dependent on oslo.messaging

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

What about the libraries involved when that middlware moves out of the incubator?

Revision history for this message
gordon chung (chungg) wrote :

dhellmann, hmm....

right now the audit middleware in pycadf (oslo.middleware) is tied to oslo.messaging... nova would be tied to pycadf (oslo.middleware), etc.

i would think as long as oslo.messaging doesn't gain a dependency on any of the core projects we should be ok.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

If pycadf depends on oslo.messaging, then no other oslo library will be allowed to depend on pycadf. Maybe that's not a problem, but I want to make sure we've thought it out.

Revision history for this message
gordon chung (chungg) wrote :

doug, that's fine. if/when we move audit middleware to oslo.middleware, the oslo.messaging dependency in pycadf will be removed.

Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-3 → 2014.1
Revision history for this message
Steve Martinelli (stevemar) wrote :

I think we can mark this as invalid now since we removed the messaging bits

Dolph Mathews (dolph)
Changed in pycadf:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.