Fuel cli. Remove nodes with inapropriate env id.

Bug #1286091 reported by Egor Kotko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Alexandr Notchenko

Bug Description

{"build_id": "2014-02-28_01-17-30", "mirantis": "yes", "build_number": "225", "nailgun_sha": "12a7e7a99557f2bc302f0806ad3beef02e94b974", "ostf_sha": "ceb3ea8c2c0da27306b30b9936f27dbc5044d2c6", "fuelmain_sha": "ba019bf15a9597a154e7c1d6ecc840614d21414c", "astute_sha": "f15f5615249c59c826ea05d26707f062c88db32a", "release": "4.1", "fuellib_sha": "61d3a150402da3ce1160836c8d659f6d9d1f9640"}

Steps to reproduce via cli:
1. fuel env create --name=test --rel=1
2. fuel node -s --env 2 --node-id=12 --role=controller
3. fuel nodes

id | status | name | cluster | mac | roles | pending_roles | online
---|----------|------------------|---------|-------------------|-------|-----------------|-------
12 | discover | Untitled (C3:FF) | 2 | 52:54:00:d2:c3:ff | [] | [u'controller'] | True

4. fuel env

id | status | name | mode | release_id | changes
---|--------|---------|------------|------------|----------------------------------------------------------------------------------------------------------------------------
1 | new | stambul | ha_compact | 2 | [{u'node_id': None, u'name': u'attributes'}, {u'node_id': None, u'name': u'networks'}, {u'node_id': 3, u'name': u'disks'}]
2 | new | test | multinode | 1 | [{u'node_id': None, u'name': u'attributes'}, {u'node_id': None, u'name': u'networks'}, {u'node_id': 12, u'name': u'disks'}]

5. fuel node remove --node 12 --env 35

Actual Result :
Node was removed from cluster with id 2

Expected result:
Node should not be removed because id of cluster in commend was inappropriate.

Tags: cli
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77572

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/77572
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=036f65d5dda55afc5b0c71b6f3bd0cb1fb751b07
Submitter: Jenkins
Branch: master

commit 036f65d5dda55afc5b0c71b6f3bd0cb1fb751b07
Author: Alexandr Notchenko <email address hidden>
Date: Mon Mar 3 15:50:19 2014 +0400

    Remove nodes only with correct environment ids

     * Fix in node unassignment handler's validator
     * Also fixed IvalidData error response formatting
     * Extended test for unassignment validation

     Closes-Bug: #1286091
     Closes-Bug: #1286036

    Change-Id: Ie50954a5b043aa8141188bea345112232b6b7f57

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

Verified on fuel_5_0_iso#21

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.