OpenStack Dashboard (Horizon)

Improve handle method on ManageAggregateHostWorkflow class

Bug #1287192 reported by Facundo Farias
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Alejandro Emanuel Paredes
OpenStack Dashboard (Horizon) 2014.1 "icehouse"

Bug Description

As it is said here: https://review.openstack.org/#/c/71061/12/openstack_dashboard/dashboards/admin/aggregates/workflows.py, the Workflows.py file contains the ManageAggregateHostWorkflow class. Inside it, the handle method should be improved (check the comments on the review). It will be ready to fix when the bp https://blueprints.launchpad.net/horizon/+spec/manage-host-aggregates was finished.

Facundo Farias (facundo-farias)
Changed in horizon:
assignee: nobody → Facundo Farias (facundo-farias)
Julie Pichon (jpichon)
Changed in horizon:
milestone: none → icehouse-rc1
Alejandro Emanuel Paredes (alejandro-e-paredes)
Changed in horizon:
assignee: Facundo Farias (facundo-farias) → Alejandro Emanuel Paredes (alejandro-e-paredes)
Julie Pichon (jpichon)
Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79456

Changed in horizon:
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-rc1 → next
Revision history for this message
Julie Pichon (jpichon) wrote :

I would really like to suggest getting this into the RC, the current way of changing host aggregates is unsafe and the patch to fix this is well tested and pretty much ready. Thank you.

Revision history for this message
Alejandro Emanuel Paredes (alejandro-e-paredes) wrote :

Agree with you Julie. Thanks!

Julie Pichon (jpichon)
tags: added: icehouse-backport-potential
Changed in horizon:
importance: Medium → High
Julie Pichon (jpichon)
Changed in horizon:
milestone: next → juno-1
Julie Pichon (jpichon)
tags: added: icehouse-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/79456
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8f4331a6bdc12bb7632f2d170cc94176e0897fbf
Submitter: Jenkins
Branch: master

commit 8f4331a6bdc12bb7632f2d170cc94176e0897fbf
Author: Alejandro Emanuel Paredes <email address hidden>
Date: Mon Mar 10 18:14:07 2014 -0300

    Improve Host Aggregates handle method.

    Added update conditions to the handle method (remove
    and add hosts).
    Previously, to perform an update, first all existing hosts
    were removed and then all new hosts were added.
    Now, the update method only
    remove or add the changed hosts.
    Added missing unit tests for the update.

    Change-Id: I52acdd1226be504cf2d0cf029353dbf80e4aa01a
    Closes-bug: #1287192

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85263

Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → icehouse-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (milestone-proposed)

Reviewed: https://review.openstack.org/85263
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=09981bdb5a8675517f8c59578b0760ef1eb4a7eb
Submitter: Jenkins
Branch: milestone-proposed

commit 09981bdb5a8675517f8c59578b0760ef1eb4a7eb
Author: Alejandro Emanuel Paredes <email address hidden>
Date: Mon Mar 10 18:14:07 2014 -0300

    Improve Host Aggregates handle method.

    Added update conditions to the handle method (remove
    and add hosts).
    Previously, to perform an update, first all existing hosts
    were removed and then all new hosts were added.
    Now, the update method only
    remove or add the changed hosts.
    Added missing unit tests for the update.

    Change-Id: I52acdd1226be504cf2d0cf029353dbf80e4aa01a
    Closes-bug: #1287192
    (cherry picked from commit 8f4331a6bdc12bb7632f2d170cc94176e0897fbf)

Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.