Keystone fails when returning unscoped federated token as XML

Bug #1294150 reported by Marek Denis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Marek Denis
openstack-api-site
Fix Released
Undecided
Dolph Mathews

Bug Description

Keystone fails when unscoped token is serialized to the XML output. 'OS-FEDERATION:groups' tag is invalid.

Traceback:

ERROR keystone.middleware.core Serializer failed
TRACE keystone.middleware.core Traceback (most recent call last):
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/middleware/core.py", line 167, in process_response
TRACE keystone.middleware.core response.body = serializer.to_xml(body_obj)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 67, in to_xml
TRACE keystone.middleware.core return serialize(d, xmlns)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 218, in __call__
TRACE keystone.middleware.core self.populate_element(root, d[name])
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 323, in populate_element
TRACE keystone.middleware.core self._populate_tree(element, value)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 357, in _populate_tree
TRACE keystone.middleware.core self._populate_dict(element, k, v)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 294, in _populate_dict
TRACE keystone.middleware.core self.populate_element(child, v)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 323, in populate_element
TRACE keystone.middleware.core self._populate_tree(element, value)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 359, in _populate_tree
TRACE keystone.middleware.core self._populate_list(element, k, v)
TRACE keystone.middleware.core File "/opt/stack/keystone/keystone/common/serializer.py", line 272, in _populate_list
TRACE keystone.middleware.core container = etree.Element(k)
TRACE keystone.middleware.core File "lxml.etree.pyx", line 2811, in lxml.etree.Element (src/lxml/lxml.etree.c:65352)
TRACE keystone.middleware.core File "apihelpers.pxi", line 103, in lxml.etree._makeElement (src/lxml/lxml.etree.c:13888)
TRACE keystone.middleware.core File "apihelpers.pxi", line 1575, in lxml.etree._tagValidOrRaise (src/lxml/lxml.etree.c:27942)
TRACE keystone.middleware.core ValueError: Invalid tag name u'OS-FEDERATION:groups'

Changed in keystone:
assignee: nobody → Marek Denis (marek-denis)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81277

Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Changed in openstack-api-site:
assignee: nobody → Dolph Mathews (dolph)
Changed in openstack-api-site:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to identity-api (master)

Reviewed: https://review.openstack.org/81022
Committed: https://git.openstack.org/cgit/openstack/identity-api/commit/?id=654f9b98743a1c0c92b0052a74b607ef54b7ba32
Submitter: Jenkins
Branch: master

commit 654f9b98743a1c0c92b0052a74b607ef54b7ba32
Author: Dolph Mathews <email address hidden>
Date: Mon Mar 17 12:09:36 2014 -0500

    merge OS-FEDERATION objects together

    this avoids using using colons in keys, which cannot be used in XML tag
    names

    Change-Id: Iac866c7071d7e7e27478cae51f2bc8cc0363e68f
    Closes-Bug: 1294150

Changed in openstack-api-site:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/81277
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a680f43904b2846c22ff3f553752a9b3be91bf1d
Submitter: Jenkins
Branch: master

commit a680f43904b2846c22ff3f553752a9b3be91bf1d
Author: Marek Denis <email address hidden>
Date: Tue Mar 18 15:39:06 2014 +0100

    Store groups ids objects list in the OS-FEDERATION object.

    When issuing unscoped federated token store groups ids
    object in the OS-FEDERATION objects instead of standalone
    OS-FEDERATION:groups.

    Change-Id: I116466c6eefae674d2245796dfd608b12d5d3e6d
    Closes-Bug: #1294150

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.