OpenStack Identity (keystone)

Managers instantiated multiple times

Bug #1294994 reported by Morgan Fainberg
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Morgan Fainberg
OpenStack Identity (keystone) 2014.2 "juno"
Icehouse
Fix Released
Medium
Morgan Fainberg
OpenStack Identity (keystone) 2014.1.3

Bug Description

A number of the managers are instantiated multiple times and this can cause odd edge cases where they will have differing dependency injection results, differing configurations, etc.

Morgan Fainberg (mdrnstm)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81720

Changed in keystone:
assignee: nobody → Morgan Fainberg (mdrnstm)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in keystone:
assignee: Morgan Fainberg (mdrnstm) → Dolph Mathews (dolph)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/81720
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=0a1cb0e20247a3c7856b409452b01ad6db8069f0
Submitter: Jenkins
Branch: master

commit 0a1cb0e20247a3c7856b409452b01ad6db8069f0
Author: Morgan Fainberg <email address hidden>
Date: Wed Mar 19 23:17:07 2014 -0700

    Remove extraenous instantiations of managers

    There were cases where a number of the API managers were being
    instantiated more than one time. This could cause a number of
    odd edge cases where the managers would have different
    configurations and/or different dependency injection results.

    The managers should now be properly instantiated only once
    unless explicitly required (e.g. testing the token provider
    manager raises an exception in badly configured states).

    Closes-Bug: #1294994
    Change-Id: I1babb065065cb5b06899f59568020a1c38f1156c

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Dolph Mathews (dolph)
Changed in keystone:
assignee: Dolph Mathews (dolph) → Morgan Fainberg (mdrnstm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/120924

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/icehouse)

Reviewed: https://review.openstack.org/120924
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a391713b6216ad13a1aa6e1e9fbf947923fed433
Submitter: Jenkins
Branch: stable/icehouse

commit a391713b6216ad13a1aa6e1e9fbf947923fed433
Author: Morgan Fainberg <email address hidden>
Date: Thu Sep 11 15:28:16 2014 -0700

    Remove extraenous instantiations of managers

    There were cases where a number of the API managers were being
    instantiated more than one time. This could cause a number of
    odd edge cases where the managers would have different
    configurations and/or different dependency injection results.

    The managers should now be properly instantiated only once
    unless explicitly required (e.g. testing the token provider
    manager raises an exception in badly configured states).

    Conflicts:
     keystone/auth/plugins/token.py

    Closes-Bug: #1294994
    Change-Id: I1babb065065cb5b06899f59568020a1c38f1156c
    (cherry-picked from commit 0a1cb0e20247a3c7856b409452b01ad6db8069f0)

Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.