Ceilometer

ceilometer combination alarm should not allow dupicate alarm ids

Bug #1304886 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
ZhiQiang Fan
Ceilometer 2014.2 "juno"

Bug Description

$ ceilometer alarm-combination-create --name test-comb --alarm_ids bfa5d625-019c-4f34-b31c-d4cfba3bae1f --alarm_ids bfa5d625-019c-4f34-b31c-d4cfba3bae1f
+---------------------------+----------------------------------------------------------------------+
| Property | Value |
+---------------------------+----------------------------------------------------------------------+
| alarm_actions | [] |
| alarm_id | 68356318-c610-4231-8f6e-57ed88247ee2 |
| alarm_ids | [u'bfa5d625-019c-4f34-b31c-d4cfba3bae1f', u'bfa5d625-019c-4f34-b31c- |
| | d4cfba3bae1f'] |
| description | Combined state of alarms bfa5d625-019c-4f34-b31c-d4cfba3bae1f and |
| | bfa5d625-019c-4f34-b31c-d4cfba3bae1f |
| enabled | True |
| insufficient_data_actions | [] |
| name | test-comb |
| ok_actions | [] |
| operator | and |
| project_id | 9ed07847a89c4b4fb0d0a1a079f84904 |
| repeat_actions | False |
| state | insufficient data |
| type | combination |
| user_id | ae493c20da534b1c89a96fe5ed4fef3b |
+---------------------------+----------------------------------------------------------------------+

I think we should remove the duplicate alarm ids

ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86501

Changed in ceilometer:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/86501
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=a12669f4366dd62a910f58a665169129b045714c
Submitter: Jenkins
Branch: master

commit a12669f4366dd62a910f58a665169129b045714c
Author: ZhiQiang Fan <email address hidden>
Date: Thu Apr 10 12:27:35 2014 +0800

    Remove duplicate alarm from alarm_ids

    Alarm ids in combination rule is a list, and for now, we allow duplicate
    alarms, the duplicate alarms are unnecessary to handle when evaluate a
    combination alarm, and it is weird when print the combination rule.

    This patch will remove duplicate alarm ids when user try to post or put
    combination alarm.

    Change-Id: Ic9392355e08834b4d01b0e421de1c77fed8ac5e4
    Closes-Bug: #1304886

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ceilometer (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/89229

Eoghan Glynn (eglynn)
Changed in ceilometer:
importance: Undecided → Medium
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (stable/havana)

Change abandoned by ZhiQiang Fan (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/89229
Reason: not security related

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.