Ceilometer

A bugfix in WSME for correcting the default values caused a test failure in _validate_query

Bug #1315926 reported by Ildiko Vancsa
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Critical
Balazs Gibizer
Ceilometer 2014.2 "juno"
Havana
Invalid
Critical
Ildiko Vancsa
Icehouse
Fix Released
Critical
Ildiko Vancsa
Ceilometer 2014.1.1

Bug Description

The new version of WSME, which was released on 2nd May contains a bugfix, which changes the handling of default values for the Unset fields. The bug report for this fix in WSME: https://bugs.launchpad.net/wsme/+bug/1291084

In Ceilometer there are some tests, which check the error message text. One of these checked the error message for invalid field name in simple queries. This text contained 'None', when the type of the meter was not specified. After the WSME bugfix, the default value has been changed to '', which cause the test failure, as the expected text is: [<Query u\'non_valid_field_name\' eq u\'3\' None>]' and the returned text is: [<Query u\'non_valid_field_name\' eq u\'3\' >].

Ildiko Vancsa (ildiko-vancsa)
Changed in ceilometer:
importance: Undecided → Critical
Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :

Fix proposed https://review.openstack.org/#/c/92020/1

Changed in ceilometer:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/92020
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=64697095e5f486c7fe7208410f2c4a18573a7dc0
Submitter: Jenkins
Branch: master

commit 64697095e5f486c7fe7208410f2c4a18573a7dc0
Author: Balazs Gibizer <email address hidden>
Date: Sun May 4 20:59:57 2014 +0200

    Adapt failing tests for latest wsme version

    Some error message has been changed with the 0.6.1 wsme version due to
    the fixed default value handling in wsme.

    See 9c8a033415606667eca915c863165e5f9021bccb in wsme repo

    Change-Id: I93b7138dcef1fb9e9b0d71661c8bc5a6344adb35
    Closes-bug: #1315926

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ceilometer (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/92202

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to ceilometer (stable/icehouse)

Reviewed: https://review.openstack.org/92202
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=94c12fd76c8b92a4d25f952fc760466c22213fe2
Submitter: Jenkins
Branch: stable/icehouse

commit 94c12fd76c8b92a4d25f952fc760466c22213fe2
Author: Balazs Gibizer <email address hidden>
Date: Sun May 4 20:59:57 2014 +0200

    Adapt failing tests for latest wsme version

    Some error message has been changed with the 0.6.1 wsme version due to
    the fixed default value handling in wsme.

    See 9c8a033415606667eca915c863165e5f9021bccb in wsme repo

    Change-Id: I93b7138dcef1fb9e9b0d71661c8bc5a6344adb35
    Closes-bug: #1315926
    (cherry picked from commit 64697095e5f486c7fe7208410f2c4a18573a7dc0)

tags: added: in-stable-icehouse
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ceilometer (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/92335

Ildiko Vancsa (ildiko-vancsa)
Changed in ceilometer:
milestone: none → juno-1
Alan Pevec (apevec)
tags: removed: in-stable-icehouse
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (stable/havana)

Change abandoned by Ildiko Vancsa (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/92335
Reason: I will propose this again, if it will be needed.

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.