Integer max values are not being properly validated in oslo.config

Bug #1329478 reported by David Stanek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
High
David Stanek

Bug Description

The following option declaration is not being validated at all:

    cfg.Opt('max_password_length',
            type=cfg.types.Integer(max=passlib.utils.MAX_PASSWORD_SIZE),
            default=4096,
            help='Maximum supported length for user passwords; '
                      'decrease to improve performance.'),

This is because the ValueError is returned instead of being raised. The calling code doesn't realize that a validation error occurred.

Accessing identity.max_password_length should cause an exception to be raised.

Tags: config
David Stanek (dstanek)
Changed in oslo:
assignee: nobody → David Stanek (dstanek)
description: updated
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :
Changed in oslo:
status: New → Triaged
importance: Undecided → High
tags: added: config
Changed in oslo:
status: Triaged → In Progress
Changed in oslo:
status: In Progress → Fix Committed
milestone: none → juno-2
Changed in oslo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.