AnonymousShmFile tests are not parallel-safe
Bug #1333175 reported by
Alan Griffiths
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Cemil Azizoglu | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
If running tests in parallel (e.g. "ctest -j256") intermittent failures will be seen in this test suite.
The reason being that it monitors the filesystem in a place that is shared with other tests.
I'm ignoring the related question about whether a test that touches the filesystem is truly a "unit test".
Related branches
lp://qastaging/~cemil-azizoglu/mir/use_tmpfile_if_kernel_supports
- Alexandros Frantzis (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alberto Aguirre (community): Approve
- Alan Griffiths: Approve
-
Diff: 367 lines (+58/-218)5 files modifiedcmake/MirCommon.cmake (+16/-1)
cmake/src/mir/mir_discover_gtest_tests.cpp (+19/-1)
debian/control (+1/-1)
src/platform/graphics/mesa/anonymous_shm_file.cpp (+13/-23)
tests/unit-tests/graphics/mesa/test_anonymous_shm_file.cpp (+9/-192)
| Changed in mir: | |
| importance: | Undecided → Medium |
| tags: | added: testsfail |
Revision history for this message
| Alexandros Frantzis (afrantzis) wrote | #1 |
| Changed in mir: | |
| status: | New → Fix Committed |
| assignee: | nobody → Cemil Azizoglu (cemil-azizoglu) |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in mir: | |
| milestone: | none → 0.9.0 |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
| Changed in mir (Ubuntu): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Should be fixed by the new code using only /dev/shm.