Static IP range can be changed with no checks that it would exclude currently allocated IPs
Bug #1338402 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Graham Binns | ||
Bug Description
There are no validation checks on the static range other than to make sure it's inside the interface's network.
There needs to be another check to make sure any changes don't leave currently allocated IPs in limbo outside of the new range.
Related branches
lp://qastaging/~gmb/maas/static-ip-sanity-checks
- Julian Edwards (community): Approve
-
Diff: 114 lines (+30/-16)2 files modifiedsrc/maasserver/forms.py (+5/-4)
src/maasserver/tests/test_forms.py (+25/-12)
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| milestone: | none → 1.6.0 |
| Changed in maas: | |
| assignee: | nobody → Graham Binns (gmb) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| tags: | added: needs-qa |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
| tags: |
added: qa-bad removed: needs-qa |
| tags: |
added: qa-ok removed: qa-bad |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I just played with this and set the lower or upper bound to the same as my allocated IP, and it failed verification. If I moved one beyond that on either bound, it was OK.
The new range should not require me to move one beyond the allocated address.