puppet-nova

The operatingsystemrelease fact might not be a comparable number

Bug #1338777 reported by Mathieu Gagné
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-ceilometer
Fix Released
Undecided
Gael Chamoulaud
puppet-ceilometer 5.0.0 "5.0.0"
puppet-cinder
Fix Released
Undecided
Gael Chamoulaud
puppet-cinder 5.0.0 "5.0.0"
Icehouse
Fix Released
Undecided
Unassigned
puppet-cinder 4.2.0 "4.2.0"
puppet-nova
Fix Released
Undecided
Gael Chamoulaud
puppet-nova 5.0.0 "5.0.0"
Icehouse
Fix Released
Undecided
Unassigned
puppet-nova 4.2.0 "4.2.0"

Bug Description

In some cases, the operatingsystemrelease fact might not be a comparable number.

We have several places where a numeric comparison is done against this fact.

One occurrence of it not being a number is with CentOS 7, the value is actually 7.0.1406.

We should use the operatingsystemmajrelease fact whenever possible or find an alternative solution.

OpenStack Infra (hudson-openstack)
Changed in puppet-nova:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/105673

Changed in puppet-cinder:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/105685

Changed in puppet-ceilometer:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/105673
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=c18884bdb9b47f1c23f9a728a5ff6c4c66a1801a
Submitter: Jenkins
Branch: master

commit c18884bdb9b47f1c23f9a728a5ff6c4c66a1801a
Author: Gael Chamoulaud <email address hidden>
Date: Wed Jul 9 10:22:17 2014 +0200

    Fixes Facts string comparisons in CentOS 7

    - CentOS Project has adopted a new rule for versioning numbers. The major number
      matches the RHEL major number, but the minor number is generated from the
      release date. For example, CentOS 7.1407.
    - Adds support for Scientific Linux.

    Change-Id: I183dd8e0a019d5fb486e8f0641f6ab81ae758f8f
    Closes-Bug: 1338777
    Signed-off-by: Gael Chamoulaud <email address hidden>

Changed in puppet-cinder:
status: In Progress → Fix Committed
Changed in puppet-nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/105526
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=0ed5b7745b6b200cdda4ae6b7d88af71498361e4
Submitter: Jenkins
Branch: master

commit 0ed5b7745b6b200cdda4ae6b7d88af71498361e4
Author: Gael Chamoulaud <email address hidden>
Date: Tue Jul 8 18:54:04 2014 +0200

    Fixes Facts string comparisons in CentOS 7

    - CentOS Project has adopted a new rule for versioning numbers. The major number
      matches the RHEL major number, but the minor number is generated from the
      release date. For example, CentOS 7.1407.
    - Adds Support for Scientific Linux.

    Change-Id: I8ffb63ba3409c7595a0f13b5ec93c87b1d534d02
    Closes-Bug: 1338777
    Signed-off-by: Gael Chamoulaud <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/105807

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/105809

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceilometer (master)

Reviewed: https://review.openstack.org/105685
Committed: https://git.openstack.org/cgit/stackforge/puppet-ceilometer/commit/?id=cca209f8b1fb37c611194030ba0701ab2a4134aa
Submitter: Jenkins
Branch: master

commit cca209f8b1fb37c611194030ba0701ab2a4134aa
Author: Gael Chamoulaud <email address hidden>
Date: Wed Jul 9 11:52:25 2014 +0200

    Fixes Facts string comparisons in CentOS 7

    - CentOS Project has adopted a new rule for versioning numbers. The major number
      matches the RHEL major number, but the minor number is generated from the
      release date. For example, CentOS 7.0.1407.
    - Adds Support for Scientific Linux.

    Change-Id: I3220206aa01b9f5c838e524b3fec723c92435153
    Closes-Bug: 1338777
    Signed-off-by: Gael Chamoulaud <email address hidden>

Changed in puppet-ceilometer:
status: In Progress → Fix Committed
tags: added: in-stable-icehouse
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (stable/icehouse)

Reviewed: https://review.openstack.org/105809
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=445b926959658371789666c46899fb3cb2bcd2e6
Submitter: Jenkins
Branch: stable/icehouse

commit 445b926959658371789666c46899fb3cb2bcd2e6
Author: Gael Chamoulaud <email address hidden>
Date: Wed Jul 9 10:22:17 2014 +0200

    Fixes Facts string comparisons in CentOS 7

    - CentOS Project has adopted a new rule for versioning numbers. The major number
      matches the RHEL major number, but the minor number is generated from the
      release date. For example, CentOS 7.1407.
    - Adds support for Scientific Linux.

    Change-Id: I183dd8e0a019d5fb486e8f0641f6ab81ae758f8f
    Closes-Bug: 1338777
    Signed-off-by: Gael Chamoulaud <email address hidden>
    (cherry picked from commit c18884bdb9b47f1c23f9a728a5ff6c4c66a1801a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceilometer (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/106035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (stable/icehouse)

Reviewed: https://review.openstack.org/105807
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=0b7b93fea44d79ef6eecb3ab9c83cf60c1951bfb
Submitter: Jenkins
Branch: stable/icehouse

commit 0b7b93fea44d79ef6eecb3ab9c83cf60c1951bfb
Author: Gael Chamoulaud <email address hidden>
Date: Tue Jul 8 18:54:04 2014 +0200

    Fixes Facts string comparisons in CentOS 7

    - CentOS Project has adopted a new rule for versioning numbers. The major number
      matches the RHEL major number, but the minor number is generated from the
      release date. For example, CentOS 7.1407.
    - Adds Support for Scientific Linux.

    Change-Id: I8ffb63ba3409c7595a0f13b5ec93c87b1d534d02
    Closes-Bug: 1338777
    Signed-off-by: Gael Chamoulaud <email address hidden>
    (cherry picked from commit 0ed5b7745b6b200cdda4ae6b7d88af71498361e4)

Revision history for this message
Gael Chamoulaud (gael-chamoulaud) wrote :

@mgagne, I am confused about the fix in the puppet-ceilometer module, because I don't think this module is impacted by the new CentOS versioning.

Any thoughts about why did you put it in the list of affected modules ?

Cheers,
Gaël.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-ceilometer (stable/icehouse)

Change abandoned by Gael Chamoulaud (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/106035

Mathieu Gagné (mgagne)
Changed in puppet-cinder:
milestone: none → 5.0.0
status: Fix Committed → Fix Released
Changed in puppet-nova:
milestone: none → 5.0.0
status: Fix Committed → Fix Released
Changed in puppet-ceilometer:
milestone: none → 5.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.