Mixdown actions don't display if user doesn't have Pidgin running

Bug #134181 reported by Tommy
2
Affects Status Importance Assigned to Milestone
Jokosher
Fix Released
Critical
David Corrales

Bug Description

Jokosher Version - 0.9 from Bazaar (Launchpad - date 23/08/2007)

If Jokosher and Pidgin are both installed, and the DBus extension is installed too (regardless of whether it is enabled or not), Jokosher tries, and fails (if Pidgin isn't running), to communicate with Pidgin to change it's away message. The following exception occurs:

Traceback (most recent call last):
  File "/home/tom/Documents/programming/jokosher/trunk/Jokosher/MixdownProfileDialog.py", line 474, in OnAddAction
    self.ShowAddActionDialog()
  File "/home/tom/Documents/programming/jokosher/trunk/Jokosher/MixdownProfileDialog.py", line 505, in ShowAddActionDialog
    AddMixdownActionDialog(self)
  File "/home/tom/Documents/programming/jokosher/trunk/Jokosher/MixdownProfileDialog.py", line 619, in __init__
    self.PopulateActionModel()
  File "/home/tom/Documents/programming/jokosher/trunk/Jokosher/MixdownProfileDialog.py", line 673, in PopulateActionModel
    for action in self.ReturnAllActions():
  File "/home/tom/Documents/programming/jokosher/trunk/Jokosher/MixdownProfileDialog.py", line 663, in ReturnAllActions
    actionList.append( action() )
  File "build/bdist.linux-i686/egg/PidginExtension/PidginExtension.py", line 41, in __init__
  File "/var/lib/python-support/python2.5/dbus/_dbus.py", line 410, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 230, in __init__
    _dbus_bindings.UInt32(0))
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 169, in __call__
    reply_message = self._connection.send_message_with_reply_and_block(message, timeout)
dbus.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name im.pidgin.purple.PurpleService was not provided by any .service files

Rather than just catching the exception and hiding it, Jokosher refuses to show any of the other mixdown options (although it WILL display the window from which the user would normally choose the mixdown options).

I think the only real problem is the exception handling - Jokosher needs to gracefully move on if one plugin from a list fails, rather than give up.

As a free bonus suggestion - if the Mixdown options dialog is going to have no actual options for the user - it'd be a bit friendlier if a little message popped up saying something like 'No mixdown extensions installed' or something to that effect. I was a bit confused when I first saw the blank box!

Tommy (tom-h)
description: updated
Jono Bacon (jonobacon)
Changed in jokosher:
importance: Undecided → Critical
Jono Bacon (jonobacon)
Changed in jokosher:
status: New → Confirmed
Revision history for this message
David Corrales (davidcorrales) wrote :

I added a temporary fix that allows the usage of the mixdown dialog again, by disabling the pidgin mixdown action.

Ideally, we'll incorporate a new method in the extensions so that Jokosher can check if they can function properly before enabling them fully.

Changed in jokosher:
assignee: nobody → davidcorrales
status: Confirmed → In Progress
Jono Bacon (jonobacon)
Changed in jokosher:
status: In Progress → Fix Committed
Laszlo Pandy (laszlok)
Changed in jokosher:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.