manage.py validate not exiting with error if problems are found.

Bug #1349598 reported by Daniel Manrique
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PlainBox (Toolkit)
Fix Released
High
Zygmunt Krynicki

Bug Description

A recent merge request introduced borked jobs (with duplicated estimated_duration). These were missed by the containerized tests.

I ran ./manage.py validate in the affected provider manually, and the test failed as it should have (at least, found and reported the error), but manage.py validate eventually exits with success. ANd it even says "all jobs seem to be valid".

./manage.py validate && echo $?
WARNING plainbox.secure.plugins: Unable to prepare plugin /src/checkbox/git/providers/plainbox-provider-checkbox/jobs/stress.txt.in: Cannot load job definitions from '/src/checkbox/git/providers/plainbox-provider-checkbox/jobs/stress.txt.in': Job has a duplicate key 'estimated_duration' with old value '7200.0\n' and new value '7200.0\n' (line 4)
Cannot load job definitions from '/src/checkbox/git/providers/plainbox-provider-checkbox/jobs/stress.txt.in': Job has a duplicate key 'estimated_duration' with old value '7200.0\n' and new value '7200.0\n' (line 4)
NOTE: subsequent units from problematic files are ignored
All jobs seem to be valid
0

I'm not sure what is needed for this to properly halt a merge, but it'd be a good idea to think about enabling it soon :)

Related branches

Zygmunt Krynicki (zyga)
Changed in plainbox:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Zygmunt Krynicki (zkrynicki)
milestone: none → 0.9
Zygmunt Krynicki (zyga)
Changed in plainbox:
status: In Progress → Fix Committed
Changed in plainbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.