manage.py validate not exiting with error if problems are found.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
PlainBox (Toolkit) |
Fix Released
|
High
|
Zygmunt Krynicki |
Bug Description
A recent merge request introduced borked jobs (with duplicated estimated_
I ran ./manage.py validate in the affected provider manually, and the test failed as it should have (at least, found and reported the error), but manage.py validate eventually exits with success. ANd it even says "all jobs seem to be valid".
./manage.py validate && echo $?
WARNING plainbox.
Cannot load job definitions from '/src/checkbox/
NOTE: subsequent units from problematic files are ignored
All jobs seem to be valid
0
I'm not sure what is needed for this to properly halt a merge, but it'd be a good idea to think about enabling it soon :)
Related branches
- Daniel Manrique (community): Approve
-
Diff: 41 lines (+5/-5)1 file modifiedplainbox/plainbox/provider_manager.py (+5/-5)
Changed in plainbox: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Zygmunt Krynicki (zkrynicki) |
milestone: | none → 0.9 |
Changed in plainbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox: | |
status: | Fix Committed → Fix Released |