OpenStack DBaaS (Trove)

Trove replication verify volume size based on master

Bug #1357500 reported by Iccha Sethi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Yao Wang
OpenStack DBaaS (Trove) ongoing

Bug Description

The slave should have minimum volume same as master. The reason why I think we should be doing this is -
the user builds master with a certain volume size because they expect it to grow atleast that much. so we should make sure the slave has volume size atleast as much as the master.

Revision history for this message
Denis M. (dmakogon) wrote :

Completely agree. Slave storage size should be at least the same as master. That's what i pointed out when i've described 6 cases when replication code will fail. See https://review.openstack.org/#/c/98147/23/trove/instance/models.py,cm

Nikhil Manchanda (slicknik)
Changed in trove:
status: New → Triaged
importance: Undecided → Medium
milestone: none → ongoing
Revision history for this message
Amrith Kumar (amrith) wrote :

Retained importance to "Medium" (bugscrub, 2014-10-23)

Shayne Burgess (shayne-burgess)
Changed in trove:
assignee: nobody → Shayne Burgess (shayne-burgess)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142900

Changed in trove:
status: Triaged → In Progress
Revision history for this message
Victoria Martinez de la Cruz (vkmc) wrote :

IMO its responsibility of the operator to make sure the replica has enough space. I'm afraid that making such validations would impose an unnecessary constrain.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by Craig Vyvial (<email address hidden>) on branch: master
Review: https://review.openstack.org/142900
Reason: Abandoning due to lack activity updating this patch. Feel free to open this patch back up. Thanks.

Amrith Kumar (amrith)
Changed in trove:
assignee: Shayne Burgess (shayne-burgess) → nobody
status: In Progress → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/493563

Changed in trove:
assignee: nobody → Yao Wang (nihaome521)
status: Confirmed → In Progress
Revision history for this message
Amrith Kumar (amrith) wrote :

Absent a justification of why this is a bad thing, I have to agree with vkmc's comment from earlier.

Changed in trove:
status: In Progress → Opinion
importance: Medium → Undecided
status: Opinion → Incomplete
Revision history for this message
Yao Wang (nihaome521) wrote :

Trove provide a database management service. The user may not a dba, but he can use trove to create/management his db and don't has to worry about the database itself. So IMO this function is necessary and even user enlarge master's volume, we should automatically enlarge a slave. Actually we already did this in our on-line environment.

Revision history for this message
Amrith Kumar (amrith) wrote :

Hi Yao Wang, agreed with your comment but what you are saying is not a good user experience.

Expanding the storage is already possible; there is a resize command for that. You can't however resize down without this capability.

OpenStack Infra (hudson-openstack)
Changed in trove:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/493563
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=8e2bb674c4a82f8ced1e4849b802af6166491691
Submitter: Zuul
Branch: master

commit 8e2bb674c4a82f8ced1e4849b802af6166491691
Author: wangyao <email address hidden>
Date: Mon Aug 14 22:31:26 2017 +0800

    Add volume size verify for replica based on master

    According bug description, replica should has volume size at least
    as much as the master. Otherwise it maybe cause exception for
    replica data. To solve this problem,I added judgement for volume
    size when create a replica, which not smaller than master
    volume size. And make this function as configurable by
    CONF.verify_replica_volume_size.
    Also provide a test case to validate the method.

    Change-Id: I5e110ce672c1b1715bca1727d70d656301cd0d43
    Closes-Bug: #1357500

Changed in trove:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/trove 9.0.0.0b3

This issue was fixed in the openstack/trove 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.