Configure OSD length

I just wanted to add this bug – same here, would be a nice feature.

This is a feature I've wanted as well, although in my case I wanted the OSD to stay on screen always. The following patches against v0.3.0.2 enable a new preference in the ODS prefs pane labelled "Seconds on screen", where a value of -1 means stay on screen, and positive values mean hide after that number of seconds.

I'm not great at Python so I hope it doesn't break stuff :)

Oops, included the wrong version of the patch to osd.py in that zip. This is the correct one.

a few problems:
- patch doesn't recognize your fixed osd.py patch as valid, probably because its not in unified format and lacks a header.
- in osd.py, show() now has timeout as a mandatory argument, but then promptly overrides it with a value from settings! probably the best way to do this is give timeout a default value of None, and only if it is None use the value from settings.
- the osd prefs should show the value in ms, not s, to fit with other Exaile preferences and to allow users sub-second timeout precision. (for some people, 3.5 just feels better than 3 or 4, you know?)
- we don't accept patches for new features against stable versions, please re-base your patch against our trunk branch, lp:exaile (this also gives you a really easy way to make the patch - just use bzr diff)

How embarrassing, I corrected the issue with the missing timeout value when I "corrected" myself but forgot to generate the patch in unified diff format that time - my apologies for being so sloppy.

Also my apologies for not reading up on patch submission guidelines - I'll try to fix that up.

Here's an updated patch against the trunk branch. After playing around with it, I decided to go with zero value to mean the OSD should stay on screen.

There was still one slight bug where the osd in prefs would autohide itself because you were always ignoring the timeout argument, but after fixing that the patch works perfectly.

Committed in trunk/2752