Make the collection tree view configurable

Bug #136164 reported by Adam Olsen
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Confirmed
Wishlist
Vladimir Kokarev

Bug Description

I think it would be a good idea to have a configurable collection tree view. Just the way Amarok has one, too.
For example:
I like my tree in Amarok: "%artist --> %year - %album --> %trackname"
And perhaps someone else likes: "%artist --> %album --> %tracknumber %trackname"

This ticket was migrated from the old trac: re #719

Adam Olsen (arolsen)
Changed in exaile:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Matthias (m-kaeppler) wrote :

+1

One example why the current non-configurable view is annoying is when having sampler albums where multiple artists are present with their title on one CD. If you want to browse these albums you would typically select "Album", then select the album, but when you then expand the album tree, only the titles are shown, but not the artist names! You have to open the tag editor or add everything to the playlist first just to see what Artists are present on that album. Yikes.

Revision history for this message
Thorsten Mühlfelder (thenktor) wrote :

Yes, this would be great :)

Revision history for this message
Dan O'Reilly (oreilldf) wrote :

No configurable sorting yet (I might sit down and try adding this somewhere down the line) but this patch will fix the problem where sorting by album didn't then sort by artist, and instead went straight to sorting by track.

Revision history for this message
Farliec (farliec) wrote :

+1 for the configurable tree view !
It would be great because I really would like my tree appears like this : {genre}/{artist album}/{year} - {album}/{CD number} - {track number} - {title} ({artist singer})
Not very simple :P

It would be great to create a special album type like Amarok's "collection" type, for albums with no specific artist album (soundtracks, singles collections,...).
Then, this one would appear like this (for me) : {genre}/{album}/{CD number} - {track number} - {title} ({artist singer})

:)

reacocard (reacocard)
Changed in exaile:
assignee: nobody → Aren Olson (reacocard)
milestone: none → 0.3.x
Revision history for this message
Vladimir Kokarev (matrix47) wrote :

I've created a patch that makes collection tree more configurable (not yet in the ui though)
I've changed one of the default views 'Artist - Year - Album' to 'Artist - (Year - Album)' so that the year of the album is displayed together with it's name
That's just an example, most of requests from previous comments are also easy-to-do

The idea of the patch is that in each level of the tree we specify:
- list of tags, by which tracks are grouped at this level
- something like string mask - value, displayed in the nodes at this value
For example: tags are Year, Album, mask is '%1 - %2' (so displayed value is something like '1975 - Physical Graffiti'

Patch attached (my tree is at revision 2685 now - the latest by now)
Screenshot of working exaile with the working functionality also attached

Revision history for this message
Vladimir Kokarev (matrix47) wrote :

screenshot attachement

Revision history for this message
Vladimir Kokarev (matrix47) wrote :

by the way, with the patch tracks in the albums nodes are first sorted by disc number, then by track number
(Metallica fans will see that at the screenshot)

Revision history for this message
reacocard (reacocard) wrote :

Very interesting approach Vladimir! That does a pretty good job of encompassing everything we want to do here without dramatically increasing code complexity. If anything it makes it simpler by eliminated the hard-coded edge cases for tracknumber and such. Appears to work just fine for me too.

I'm going to give the other Exaile devs a chance to look at this before we commit this because of how core the collection panel is to Exaile, but everything looks good to me. Great work!

Changed in exaile:
assignee: Aren Olson (reacocard) → Vladimir Kokarev (matrix47)
milestone: 0.3.x → 0.3.1
status: Confirmed → In Progress
Revision history for this message
Vladimir Kokarev (matrix47) wrote :

here's one more patch

it fixes display of unicode names in tree
my previous patch has broken that
that's caused by some magic (xl.collection.search requires non-unicode string)

Revision history for this message
reacocard (reacocard) wrote :

added trunk/2690

Changed in exaile:
status: In Progress → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
Revision history for this message
Farliec (farliec) wrote :

I'm sorry but is the feature to "make the collection tree view configurable" implemented ?

I only see the new Vladimir Kokarev's tree view, but how configure a new personal view ?
Is this feature accessible to users too or only to developpers (by modifying exaile .ui files) ?

If it's only accessible by modifying .ui files - stored in file system -, are changes kept after an exaile update ?

Farliec (farliec)
Changed in exaile:
status: Fix Released → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.