stable/icehouse test listing fails with testtools>=0.9.39

Bug #1365613 reported by Nejc Saje
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Nejc Saje
Icehouse
Fix Released
Undecided
Nejc Saje

Bug Description

stable/icehouse test listing fails with testtools>=0.9.39

Nejc Saje (nejc-saje)
Changed in ceilometer:
assignee: nobody → Nejc Saje (nejc-saje)
summary: - test listing fails with testtools>=0.9.39
+ stable/icehouse test listing fails with testtools>=0.9.39
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/119156

Alan Pevec (apevec)
Changed in ceilometer:
status: New → Invalid
assignee: Nejc Saje (nejc-saje) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/icehouse)

Reviewed: https://review.openstack.org/119156
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=7ff220fc5cb4dad616b27ea6762653054df00139
Submitter: Jenkins
Branch: stable/icehouse

commit 7ff220fc5cb4dad616b27ea6762653054df00139
Author: Nejc Saje <email address hidden>
Date: Wed Sep 3 05:20:44 2014 -0400

    Fix tests with testtools>=0.9.39

    'rpc_backend' config option in
    ceilometer.openstack.common.rpc.__init__.py defaults to
    '%s.impl_kombu' % __package__. Because the RPC module is imported
    in some other files as ceilometer.openstack.common.rpc, rpc_backend
    is set to 'ceilometer.openstack.common.rpc.impl_kombu'. But when
    the test loader tries to import the RPC module as openstack.common.rpc
    (since it is starting inside the ceilometer folder), registering the
    option fails, because we try to register a different default value.

    The issue surfaced because testtools==0.9.39 started checking __init__.py
    files as well. It is fixed by passing a top-level directory parameter to
    the test discovery process.

    Change-Id: I08036b54def3eb496772bcf183927b9f70bb7a86
    Closes-bug: #1365613

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119714

Changed in ceilometer:
assignee: nobody → Nejc Saje (nejc-saje)
status: Invalid → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/119714
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=84b228410e3ad99fb2fe1becc9f59b87a47d9ea0
Submitter: Jenkins
Branch: master

commit 84b228410e3ad99fb2fe1becc9f59b87a47d9ea0
Author: Nejc Saje <email address hidden>
Date: Wed Sep 3 05:20:44 2014 -0400

    Fix tests with testtools>=0.9.39

    NOTE: the RPC module that was causing problems in Icehouse no longer
    exists in master, but the fix should be in the master as well to avoid
    future problems.

    'rpc_backend' config option in
    ceilometer.openstack.common.rpc.__init__.py defaults to
    '%s.impl_kombu' % __package__. Because the RPC module is imported
    in some other files as ceilometer.openstack.common.rpc, rpc_backend
    is set to 'ceilometer.openstack.common.rpc.impl_kombu'. But when
    the test loader tries to import the RPC module as openstack.common.rpc
    (since it is starting inside the ceilometer folder), registering the
    option fails, because we try to register a different default value.

    The issue surfaced because testtools==0.9.39 started checking __init__.py
    files as well. It is fixed by passing a top-level directory parameter to
    the test discovery process.

    (cherry picked from commit 7ff220fc5cb4dad616b27ea6762653054df00139)

    Conflicts:
     .testr.conf

    Change-Id: I08036b54def3eb496772bcf183927b9f70bb7a86
    Closes-bug: #1365613

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.