`ignore_users` and `ignore_dbs' should be per-datastore options

Bug #1374004 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Amrith Kumar

Bug Description

With respect to datastores and their options:
 `ignore_users`
 `ignore_dbs'

should be per-datastore options.

See PostgreSQL group:
https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L633-L634

(Anna S.) It should be https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L740-L741 (Feb 20, 2015)

Seems like PostgreSQL ignore users and dbs config attributes are not working because of:

https://github.com/openstack/trove/blob/8bbcc3949c3f6990be54601e1fbb043b6c5599f6/trove/extensions/mysql/models.py#L323

Denis M. (dmakogon)
description: updated
Changed in trove:
milestone: kilo-1 → kilo-2
Changed in trove:
milestone: kilo-2 → kilo-3
Anna Shen (ruiyuan-shen)
Changed in trove:
assignee: nobody → Anna Shen (ruiyuan-shen)
Changed in trove:
status: Confirmed → Triaged
Anna Shen (ruiyuan-shen)
description: updated
Changed in trove:
milestone: kilo-3 → kilo-rc1
Changed in trove:
milestone: kilo-rc1 → liberty-1
Changed in trove:
milestone: liberty-1 → liberty-2
Changed in trove:
milestone: liberty-2 → liberty-3
Changed in trove:
milestone: liberty-3 → ongoing
Changed in trove:
assignee: Anna Shen (ruiyuan-shen) → Amrith (amrith)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/207833
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=9f07d7da8dcb0c9162be479a6587f352c37f9024
Submitter: Jenkins
Branch: master

commit 9f07d7da8dcb0c9162be479a6587f352c37f9024
Author: Amrith Kumar <email address hidden>
Date: Mon Sep 14 18:32:48 2015 +0000

    Move ignore_dbs and ignore_users out of DEFAULT

    ignore_dbs and ignore_users (for MySQL) were still in DEFAULT section
    of config. Moved them to the 'mysql' section and 'percona'
    section. Sample config file(s) have been updated as well.

    Change-Id: I3a41bcb011a76343afa3bcc30013cb835e456950
    Closes-Bug: #1465242
    Closes-Bug: #1480448
    Closes-Bug: #1480447
    Closes-Bug: #1374004

Changed in trove:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/trove 5.0.0.0b1

This issue was fixed in the openstack/trove 5.0.0.0b1 development milestone.

Changed in trove:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.