Inkscape

Icon needed for menu item 'File > New from Template…'

Bug #1378338 reported by su_v on 2014-10-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Inkscape	Fix Released	Wishlist	su_v	Inkscape 0.92 "0.92"

Bug Description

The icon for 'File > New > Templates …' doesn't exist yet:
- no icon named 'dialog-templates' was added to Inkscape's own icons.svg file with the merge of the GSoC project:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12476>
- no icon named 'dialog-templates' is provided by GTK+ stock icons (fallback for icons if no icon theme is installed)

Verb referencing missing new icon ('dialog-templates'):
new FileVerb(SP_VERB_FILE_TEMPLATES, "FileTemplates", N_("_Templates..."),
N_("Create new project from template"), INKSCAPE_ICON("dialog-templates")),
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/13580/src/verbs.cpp#L2382>

(Note: The missing icon is more relevant for platforms/desktops which show menu icons (via gtk setting), and might not be exposed e.g. on GNOME-based desktops with default settings)

Tags:

Related branches

lp://qastaging/~inkscape.dev/inkscape/symbolic-icons-update

Merged into lp://qastaging/~inkscape.dev/inkscape/trunk at revision 14175

Jabiertxof: Approve (visual) on 2015-03-23

lp://qastaging/inkscape/0.91.x

su_v (suv-lp) on 2014-10-07

tags:

added: easy-fix

su_v (suv-lp) on 2014-11-23

Changed in inkscape:
milestone:	0.91 → none

jazzynico (jazzynico) on 2014-12-10

Changed in inkscape:
status:	New → Triaged

Revision history for this message

su_v (suv-lp) wrote on 2015-03-22: Re: [Bug 1378338] Re: trunk: Icon needed for menu item 'File > New > Templates …'

dialog-templates.svg Edit (5.6 KiB, image/svg+xml)

1378338-new-from-template-icon-091-v1.diff Edit (5.0 KiB, text/plain)
1378338-new-from-template-icon-r14027-v1.diff Edit (4.7 KiB, text/plain)

Icon for 'dialog-templates' attached, including diffs for current
lp:inkscape/0.91.x r13743 and lp:inkscape r14027.

The icon reuses the document symbol from Inkscape's import/export icons,
adapted based on the emblem used in the 'folder-templates' icon (context
'Places') in Gnome's default icon theme (Adwaita).

--
[ Note: the diffs here conflict with the diffs from bug #1269698 ]

Revision history for this message

su_v (suv-lp) wrote on 2015-04-20: Re: trunk: Icon needed for menu item 'File > New > Templates …'

Variant for symbolic_icons.svg is included in merge request
https://code.launchpad.net/~inkscape.dev/inkscape/symbolic-icons-update/+merge/253776

jazzynico (jazzynico) on 2015-05-11

Changed in inkscape:
assignee:	nobody → ~suv (suv-lp)
milestone:	none → 0.92
status:	Triaged → In Progress

Revision history for this message

jazzynico (jazzynico) wrote on 2015-06-29:

Patch 1378338-new-from-template-icon-r14027-v1.diff tested successfully on Windows XP (32 bit), Inkscape trunk rev. 14221.

su_v (suv-lp) on 2015-07-04

summary:	- trunk: Icon needed for menu item 'File > New > Templates …' + Icon needed for menu item 'File > New > Templates …'
summary:	- Icon needed for menu item 'File > New > Templates …' + Icon needed for menu item 'File > New from Template…'

Revision history for this message

su_v (suv-lp) wrote on 2015-07-05:

Fix committed to trunk in rev 14231.

Changed in inkscape:
status:	In Progress → Fix Committed

Revision history for this message

su_v (suv-lp) wrote on 2015-09-29:

Fix backported to 0.91.x in rev 13822.

Changed in inkscape:
milestone:	0.92 → 0.91.1

Revision history for this message

BobSongs (bobspcrepair) wrote on 2015-11-21:

icons.svg Edit (786.8 KiB, image/svg+xml)

New icons were added to the 0.91 "icons.svg" file as a temporary place-holder until a set is adopted for 0.91.1. The file is attached for review, comments, etc. Suggestions for better display in Inkscape are welcome.

icons.svg will be updated according to specifications supplied. The idea was to create Tango/GTK-style icons that would be understandable and similar to the set available in 0.48.x.

Known Issues: the icon for File>Revert does not display as large as its counterparts "File>Save" and "File>Save As". The icon embedded in icons.svg has no superfluous frame around it--its border ends at the lines of the diskette icon. However, it displays smaller than the other diskette icons below it in the File drop-down menu, making it a bit more difficult to discern at a glance.

Comments and constructive criticism welcome.

Revision history for this message

su_v (suv-lp) wrote on 2015-11-21:

@ BobSongs - thank you for your contribution. I'm not quite sure though what you want to propose: do you want me to revert the fix we already committed for the missing 'dialog-templates' icon (will be available in the next release) and use the one from your file instead ? Your alternative icon has the wrong size btw - menu icons in Inkscape's default icon set are 16x16 px.

It also seems to me that you are mixing two independent issues (with same symptoms though) which are tracked in separate reports (and both already have a fix committed for upcoming 0.91.1):

Note that icons seen missing with current Windows packages apart from the one for 'File > Templates' are tracked in bug #1269698: they miss for different reasons, as commented in the other report - we will have to properly fix directional icons code-wise (for Inkscape 0.92), but have committed a workaround solution for upcoming bug-fix release 0.91.1 which adds all missing stock icons (in 16x16 px size).

Revision history for this message

su_v (suv-lp) wrote on 2015-11-21:

@BobSongs - you could also test this file (is is the current state of the icons.svg file which will be included in upcoming bug-fix release Inkscape 0.91.1):
https://bazaar.launchpad.net/~inkscape.dev/inkscape/RELEASE_0_91_BRANCH/download/suv-sf%40users.sourceforge.net-20150929143038-76lyjyqdwzjdjsi1/icons.svg-20091128124040-aej0x7yhxng1m6ly-6894/icons.svg