Shouldn't code button's geometry, but rather let it adapt to the label
Bug #1381429 reported by
Sebastien Bacher
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Clock App |
Fix Released
|
Low
|
Nekhelesh Ramananthan |
Bug Description
Using rtm 106 on krillin
EditAlarmPage.qml contains that code
" Button {
id: _deleteAlarmButton
...
width: units.gu(17)
...
text: i18n.tr("Delete alarm")
..."
or that width is not enough in some locale which leads to a small button with a truncated string, why not just deleting the width and letting the button adapts to the label? (that's confirmed to work in e.g a french locale)
Related branches
lp://qastaging/~nik90/ubuntu-clock-app/dynamic-delete-alarm-size
- Sebastien Bacher (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Clock Developers: Pending requested
-
Diff: 166 lines (+25/-26)3 files modifiedapp/alarm/EditAlarmPage.qml (+0/-3)
debian/changelog (+2/-0)
po/com.ubuntu.clock.pot (+23/-23)
Changed in ubuntu-clock-app: | |
status: | New → Confirmed |
importance: | Undecided → Low |
assignee: | nobody → Nekhelesh Ramananthan (nik90) |
milestone: | none → rtm |
status: | Confirmed → In Progress |
Changed in ubuntu-clock-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-clock-app at revision 148, scheduled for release in ubuntu-clock-app, milestone rtm