Playlist remains populated after ejecting CD

This also triggers another (grave) problem : Exaile, at load time, will notice that these tracks can't be read, but it'll popup an error dialog for each of them, if autoresume is on. If you had a playlist with only CD tracks, you get an infinite loop of error dialogs.

I'm more the for remove tracks when ejecting approach. People will argue that they may want to unmount and remount their drive, but it'll cause less trouble for them to add their tracks again than for every other user to close dozens of error dialogs till they close the playlist or remove each CD track from it.

I am against removing tracks suddenly like that, instead i think we should simply make the error handling more robust. Specifically:

1) Display only one error dialog, stating that the track at <location> could not be found
2) Stop processing the playlist when this error is encountered.

Then what about this error dialog containing the buttons 'Remove other
tracks coming from this media' and 'Close', and what about the playback
resuming after quitting the dialog ?

Btw, I'll try to get you a vid of the problem I encountered with the CD
error dialog last time, I'm sure you'll agree that this should be fixed asap
;)

> Then what about this error dialog containing the buttons 'Remove other
tracks coming from this media'
Well, then we'd have to do a search across all open playlists to find every instance of every track from the device. Given that this would most likely apply to non-cd devices too, that could be a very large number of tracks and could be very slow. That also doesn't account for users having perhaps saved playlists containing tracks from devices into the playlists panel, in which case since it's 'saved' touching it would be bad. Additionally, how do we reverse-map a track to a device? Tracks contain no data about their origin aside from their loc, which is not a perfect indicator in all cases.

> what about the playback resuming after quitting the dialog ?
No. Having it auto-continue in any form allows for the chance of getting caught in a series of error dialogs which would be very confusing to the user. You either have to non-interactively skip problem tracks, or raise exactly one error and stop, and I think that the latter fits better in exaile.

Trunk's normal engine now halts after the first error it finds, removing the secondary bug that happens as a result of not clearing the playlist. And as I have already stated that we will NOT be auto-removing tracks from the playlist for the reasons already outlined, I'm closing this bug.