puppet-neutron

Raise puppet error if Neutron API unavailable for critical operations

Bug #1384101 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-neutron
Fix Released
Medium
Bogdan Dobrelya
puppet-neutron 6.0.0 "6.0.0"

Bug Description

https://github.com/stackforge/puppet-neutron/blob/master/lib/puppet/provider/neutron.rb#L106-108
and
https://github.com/stackforge/puppet-neutron/blob/master/lib/puppet/provider/neutron.rb#L116-118
unsafely rely on Neutron API availability, hence, should raise puppet error, if returned lists are empty due to
Neutron API is unavailable.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/130156

Changed in puppet-neutron:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (master)

Reviewed: https://review.openstack.org/130156
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=919a1016b28880b1dd295a0654987160f7776588
Submitter: Jenkins
Branch: master

commit 919a1016b28880b1dd295a0654987160f7776588
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Oct 22 10:14:11 2014 +0200

    Raise puppet error, if N-API anavail

    W/o this change, empty lists could be returned
    and broke puppet apply execution when Neutron
    (or Keystone) API is anavail.

    The solution is to raise Puppet error, if
    returned lists are empty

    Closes-bug: #1384101

    Change-Id: I10b6592f709603043e97304366c54e53703939ea
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in puppet-neutron:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-neutron:
milestone: none → 6.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187381

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (stable/juno)

Reviewed: https://review.openstack.org/187381
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=b63cc2a40a28942f777b8ffd59ef4685adff0c35
Submitter: Jenkins
Branch: stable/juno

commit b63cc2a40a28942f777b8ffd59ef4685adff0c35
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Oct 22 10:14:11 2014 +0200

    Raise puppet error, if N-API anavail

    W/o this change, empty lists could be returned
    and broke puppet apply execution when Neutron
    (or Keystone) API is anavail.

    The solution is to raise Puppet error, if
    returned lists are empty

    Closes-bug: #1384101

    Change-Id: I10b6592f709603043e97304366c54e53703939ea
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 919a1016b28880b1dd295a0654987160f7776588)

tags: added: in-stable-juno
Emilien Macchi (emilienm)
Changed in puppet-neutron:
importance: Undecided → Medium
Mathieu Gagné (mgagne)
Changed in puppet-neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.