Ceilometer

remove obsolete oslo modules and port to new libraries

Bug #1389546 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
ZhiQiang Fan
Ceilometer 2015.1.0 "kilo"
python-ceilometerclient
Invalid
Undecided
Unassigned

Bug Description

As Doug Hellmann said in http://lists.openstack.org/pipermail/openstack-dev/2014-October/048303.html

openstack/ceilometer: gettextutils
openstack/ceilometer: log_handler

we need to use new libraries instead of obsolete oslo modules, because they are no longer maintained in oslo-incubator master branch, Doug Hellmann suggest this should be before k-1, and k-2 is the deadline and that time will bring more new libraries, so seems we should keep up with oslo team.

to achieve this goal, there will be 3 steps in my plan:

1. port to new libraries, keep old code of oslo-incubator untoched, this will need to create some temporary module
2. sync oslo-incubator code to latest or some commit point which can suit our project
3. clean temporary module created in step 1

See original description
ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
ZhiQiang Fan (aji-zqfan)
description: updated
Revision history for this message
gordon chung (chungg) wrote :

ZhiQiang Fan, are you working on this? if so you can probably close this bug as we've typically just done it.. (no bug required)

Changed in ceilometer:
status: New → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137941

Changed in ceilometer:
status: Incomplete → In Progress
ZhiQiang Fan (aji-zqfan)
affects: ceilometer → python-ceilometerclient
Changed in python-ceilometerclient:
status: In Progress → New
affects: python-ceilometerclient → ceilometer
Changed in python-ceilometerclient:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
ZhiQiang Fan (aji-zqfan)
description: updated
OpenStack Infra (hudson-openstack)
Changed in ceilometer:
status: New → In Progress
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

@gordon chung

Most modules we used has no such problem, but the two I mentioned for Ceilometer, they does need to catch up with oslo team. I have upload a patch (and will have other two more) to fix this issue. Thanks!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/138820

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/138820
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=1707533e2f0ff60e2a9a448543b1bf51fa4ec495
Submitter: Jenkins
Branch: master

commit 1707533e2f0ff60e2a9a448543b1bf51fa4ec495
Author: ZhiQiang Fan <email address hidden>
Date: Thu Dec 4 02:37:40 2014 +0800

    Sync oslo-incubator code to latest

    Currently, gettextutils has graduated from oslo-incubator, so we
    need to port to new library oslo.i18n, this sync is the first move
    to do that.

    Sync to latest:
        commit 62339865b57eeaa3212ce61427feb19a8c0b0c0e
        Add more to the release notes
        Change-Id: Ifad658f532b5d549144008170bfe2e4181038ddf

    Change-Id: I3a2432ba2960c74db614e017e29bd95c560176f6
    Partial-Bug: #1389546

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/137941
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=28a253104a1c6e4d584930257e3067ae74995808
Submitter: Jenkins
Branch: master

commit 28a253104a1c6e4d584930257e3067ae74995808
Author: ZhiQiang Fan <email address hidden>
Date: Sun Nov 30 17:25:16 2014 +0800

    Port to graduated library oslo.i18n

    log_handler is not used any more by Ceilometer project, but still
    listed on openstack-common.conf, this patch fixes it.

    Note: oslo-incubator.timeutils is not used by oslo-incubator modules
    any more after we do code sync, this patch removes it too.

    gettextutils has graduated from oslo-incubator, we should port our
    project to use oslo.i18n. To use oslo.i18n conveniently, this patch
    introduces a helper module ceilometer.i18n, which is stolen from Nova.

    Note: gettextutils.install is deprecated, see:
    http://docs.openstack.org/developer/oslo.i18n/usage.html#creating-an-integration-module
    Note: _ is removed from builtins in tox.ini since we're not using
    install any more.

    Change-Id: I829f9faf97c825422b395bf9c01ae5c17c86d9fb
    Closes-Bug: #1389546

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → kilo-1
status: Fix Committed → Fix Released
ZhiQiang Fan (aji-zqfan)
Changed in python-ceilometerclient:
status: New → Invalid
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.