variables in guestagent/volume.py are too mysql specific

Bug #1393511 reported by Amrith Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Amrith Kumar

Bug Description

For example, here

https://github.com/openstack/trove/blob/master/trove/guestagent/volume.py#L38

 def migrate_data(self, mysql_base):
"""Synchronize the data from the mysql directory to the new volume."""
self.mount(TMP_MOUNT_POINT, write_to_fstab=False)
if not mysql_base[-1] == '/':
mysql_base = "%s/" % mysql_base
utils.execute("sudo", "rsync", "--safe-links", "--perms",
"--recursive", "--owner", "--group", "--xattrs",
"--sparse", mysql_base, TMP_MOUNT_POINT)
self.unmount(TMP_MOUNT_POINT)

In fact it is just volume_base and the reference to MySQL is historical.

Amrith Kumar (amrith)
Changed in trove:
assignee: nobody → Sergey Gotliv (sgotliv)
importance: Undecided → Low
milestone: none → kilo-1
Changed in trove:
assignee: Sergey Gotliv (sgotliv) → Amrith (amrith)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/129528
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=69dd414450528b32d4a150c8ae4babb91af1801c
Submitter: Jenkins
Branch: master

commit 69dd414450528b32d4a150c8ae4babb91af1801c
Author: Sergey Gotliv <email address hidden>
Date: Mon Oct 20 09:32:38 2014 +0300

    Rename generic variable named with mysql specific name

    Method migrate_data in VolumeDevice class is called by all datastores.
    Input variable "mysql_base" and method's description are misleading.

    Change-Id: I5c71018f8ce61b9673dd83f4fa790c8cd0dfc954
    Closes-Bug: #1393511

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.