variables in guestagent/volume.py are too mysql specific
Bug #1393511 reported by
Amrith Kumar
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack DBaaS (Trove) |
Fix Released
|
Low
|
Amrith Kumar |
Bug Description
For example, here
https:/
def migrate_data(self, mysql_base):
"""Synchronize the data from the mysql directory to the new volume."""
self.mount(
if not mysql_base[-1] == '/':
mysql_base = "%s/" % mysql_base
utils.execute(
"--recursive", "--owner", "--group", "--xattrs",
"--sparse", mysql_base, TMP_MOUNT_POINT)
self.unmount(
In fact it is just volume_base and the reference to MySQL is historical.
Changed in trove: | |
assignee: | nobody → Sergey Gotliv (sgotliv) |
importance: | Undecided → Low |
milestone: | none → kilo-1 |
Changed in trove: | |
assignee: | Sergey Gotliv (sgotliv) → Amrith (amrith) |
status: | New → In Progress |
Changed in trove: | |
status: | Fix Committed → Fix Released |
Changed in trove: | |
milestone: | kilo-1 → 2015.1.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/129528 /git.openstack. org/cgit/ openstack/ trove/commit/ ?id=69dd4144505 28b32d4a150c8ae 4babb91af1801c
Committed: https:/
Submitter: Jenkins
Branch: master
commit 69dd414450528b3 2d4a150c8ae4bab b91af1801c
Author: Sergey Gotliv <email address hidden>
Date: Mon Oct 20 09:32:38 2014 +0300
Rename generic variable named with mysql specific name
Method migrate_data in VolumeDevice class is called by all datastores.
Input variable "mysql_base" and method's description are misleading.
Change-Id: I5c71018f8ce61b 9673dd83f4fa790 c8cd0dfc954
Closes-Bug: #1393511