Canonical System Image

Newline not removed from the content of /custom/partner-id

Bug #1393594 reported by Alejandro J. Cura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image ww51-2014

Bug Description

If the file named above ends in a newline, it's sent verbatim to the server, which fails any attempted purchase with a 400 error.
This newline should be removed by the code opening this file, or it should be gone from the customization tarball.

Tags: rtm14

Related branches

lp://qastaging/~dobey/pay-ui/trim-partnerid
PS Jenkins bot (community): Approve (continuous-integration)
Alejandro J. Cura (community): Approve (trivial)
Diff: 14 lines (+2/-2)
1 file modified
backend/modules/payui/network.cpp (+2/-2)
Revision history for this message
dobey (dobey) wrote :

The code in pay-ui which reads this has not yet been uploaded to the store or included in the image. Are you using a locally built click of pay-ui?

I don't think this should block landing the unity-socpe-click branches to enable purchases, but we should probably block uploading the new pay-ui to the store for this.

tags: added: rtm14
removed: rtm
Revision history for this message
Alejandro J. Cura (alecu) wrote : Re: [Bug 1393594] Re: Newline not removed from the content of /custom/partner-id

Yes, I had installed a version of pay-ui from your latest branch, but
I flashed the phone after that, so I'm puzzled that this happened.
I'll try flashing with --wipe, to see if this gets fixed.

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Flashed with --wipe, and verified that this bug is invalid.

Changed in pay-ui:
status: New → Invalid
Revision history for this message
dobey (dobey) wrote :

While the bug doesn't exist on the current image or what is in the store, it does exist in trunk, so we need to fix this before uploading a new version to the store. I'll have a branch soon, which fixes this.

Changed in pay-ui:
status: Invalid → Triaged
importance: Critical → High
status: Triaged → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:pay-ui at revision 86, scheduled for release in pay-ui, milestone Unknown

Changed in pay-ui:
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww51-2014
status: New → Confirmed
dobey (dobey)
Changed in pay-ui:
status: Fix Committed → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.