OpenStack DBaaS (Trove)

Detaching a configuration group removes overrides.cnf file. This can remove internal config values

Bug #1395232 reported by Edmond Kotowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Ashleigh Farnham
OpenStack DBaaS (Trove) 2015.1.0 "kilo"

Bug Description

When you detach a configuration from an instance, the overrides.cnf gets deleted (which is by design). If the trove admin has added default configuration values into overrides.cnf then these values will get deleted when detaching a configuration group.

We should add a new config file under the same folder as overrides.cnf that way clients can manage their internal config and attach and detach configurations.

Edmond Kotowski (ekotowski)
Changed in trove:
assignee: nobody → Edmond Kotowski (ekotowski)
summary: - When you detach a configuration from an instance, the overrides.cnf gets
- deleted by design. We have some internal configs like datadir, user etc.
- If these configs are deleted, it will affect mysql. For example, it will
- error out when you do a backup. What we should do is not have these
- internal configs in the overrides.cnf.
+ Detaching a configuration group removes overrides.cnf file. This can
+ remove internal configs
summary: Detaching a configuration group removes overrides.cnf file. This can
- remove internal configs
+ remove internal config values
Edmond Kotowski (ekotowski)
Changed in trove:
status: New → Invalid
assignee: Edmond Kotowski (ekotowski) → nobody
Ashleigh Farnham (ashleighfarnham-deactivatedaccount)
Changed in trove:
status: Invalid → In Progress
assignee: nobody → Ashleigh Farnham (ashleigh-farnham)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162354

Changed in trove:
assignee: Ashleigh Farnham (ashleigh-farnham) → Ashleigh Farnham (ashleighfarnham-deactivatedaccount)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/162354
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0a70dc0116401ad9266ccd2034969c850a3d98e6
Submitter: Jenkins
Branch: master

commit 0a70dc0116401ad9266ccd2034969c850a3d98e6
Author: Ashleigh Farnham <email address hidden>
Date: Fri Mar 6 16:21:30 2015 -0800

    Update config-detach to not remove default config

    Previous behavior was we would always delete overrides.cnf
    if there were no attached configs. This causes the removal
    of default configuration data stored in overrides.cnf. To
    remedy this the file will only be removed if we had no
    content to write to it and the remove flag is set to true.
    In the event there is no default configuration the
    file will still be deleted.

    Change-Id: Ieca8cbba376b2cf7009a830e8c9a4cf2fd9169f4
    Closes-Bug:1395232

Changed in trove:
status: In Progress → Fix Committed
Nikhil Manchanda (slicknik)
Changed in trove:
importance: Undecided → High
milestone: none → kilo-3
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.