Mistral

User can delete standard workflow

Bug #1396121 reported by Anastasia Kuznetsova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Low
Nikolay Makhotkin
Mistral 1.0.0 "liberty"
Liberty
Fix Released
Low
Nikolay Makhotkin
Mistral 1.0.0 "liberty"

Bug Description

There are two 'standard' workflows: create instance and delete instance.

User can easily delete them.

We have is_system property for actions https://github.com/stackforge/mistral/blob/36298b6dc1fac756bae7ad249f1581795694793c/mistral/db/v2/sqlalchemy/models.py#L168 and don't have for workflows.

Revision history for this message
Dmitri Zimine (i-dz) wrote :

it's ok to be able to delete it, given user has a permissions.

it's a bigger problem if user can't delete it while using Mistral outside of Openstack (and the create instance worklfow is irrelevant).

Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

At this point I would make it impossible to delete artefacts like this just because they're available for all the users. If a user doesn't need them she can just ignore them. Alternatively, they may not be uploaded during the installation if we don't need them at all. I think when we have some mechanism of permissions we can get back to discussing it.

Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :

Dmitri, in your use-case when Mistral works outside the OpenStack I propose to 'hide' standard OpenStack actions and workflows and don't upload them to db at all. But in current situation I think it is not correct to provide for user ability to delete them, but don't be able to delete 'standard' actions, we need to have the same options for them

Renat Akhmerov (rakhmerov)
Changed in mistral:
status: New → Confirmed
importance: Undecided → Low
Nikolay Makhotkin (nmakhotkin)
Changed in mistral:
milestone: none → kilo-rc1
Renat Akhmerov (rakhmerov)
Changed in mistral:
milestone: kilo-rc1 → none
Renat Akhmerov (rakhmerov)
no longer affects: mistral/kilo
Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

This bug can be fixed once https://bugs.launchpad.net/mistral/+bug/1478448 is fixed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223536

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/223536
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=1c702e2555c487db25a6a26c34707368071e14ba
Submitter: Jenkins
Branch: master

commit 1c702e2555c487db25a6a26c34707368071e14ba
Author: Nikolay Mahotkin <email address hidden>
Date: Tue Sep 15 14:25:58 2015 +0300

    Adding 'is_system' to definition model

     * Fixed work of mistral-db-manage populate
     * Fixed modifying of standard workflows

    Closes-Bug: #1478448
    Closes-Bug: #1396121

    Change-Id: Ia2825408ee43a6dfc80e33fa9614e11f3ff6d97b

Changed in mistral:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.