nova::cells class references ::nova::init:* variables instead of ::nova::*

Bug #1401766 reported by Mike Dorman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-nova
Fix Released
Undecided
Mike Dorman

Bug Description

I noticed that on https://github.secureserver.net/cloudplatform/stackforge-puppet-nova/blob/master/manifests/cells.pp#L220-L224 , the rabbit_ variables here are referenced as ::nova::init::rabbit_*, instead of ::nova::rabbit_*.

On Puppet 3.7.3 with future parser, this causes the following errors:

Warning: Scope(Class[Nova::Cells]): Could not look up qualified variable '::nova::init::rabbit_userid'; class ::nova::init could not be found
Warning: Scope(Class[Nova::Cells]): Could not look up qualified variable '::nova::init::rabbit_password'; class ::nova::init could not be found
Warning: Scope(Class[Nova::Cells]): Could not look up qualified variable '::nova::init::rabbit_hosts'; class ::nova::init could not be found
Warning: Scope(Class[Nova::Cells]): Could not look up qualified variable '::nova::init::rabbit_port'; class ::nova::init could not be found
Warning: Scope(Class[Nova::Cells]): Could not look up qualified variable '::nova::init::rabbit_virtual_host'; class ::nova::init could not be found

I am not really up to speed with exported resources, so unless there is some special reason why this should be ::nova::init here, I think the init:: component of the variable names should be removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141275

Changed in puppet-nova:
assignee: nobody → Mike Dorman (mdorman-m)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/141275
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=d2fa6cadafcf1445ea241a9051b4bdf35090a2db
Submitter: Jenkins
Branch: master

commit d2fa6cadafcf1445ea241a9051b4bdf35090a2db
Author: Mike Dorman <email address hidden>
Date: Thu Dec 11 22:45:55 2014 -0700

    Correct references to ::nova::rabbit_* variables

    Change ::nova::init::rabbit_* variable references to
    ::nova::rabbit_*.

    Change-Id: Iab5b83478c33ca57a4612171df991c1927496f6f
    Closes-bug: 1401766

Changed in puppet-nova:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-nova:
milestone: none → 6.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/173554

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (stable/juno)

Reviewed: https://review.openstack.org/173554
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=843996b202e170021772e85afccda66fd38a2daa
Submitter: Jenkins
Branch: stable/juno

commit 843996b202e170021772e85afccda66fd38a2daa
Author: Mike Dorman <email address hidden>
Date: Thu Dec 11 22:45:55 2014 -0700

    Correct references to ::nova::rabbit_* variables

    Change ::nova::init::rabbit_* variable references to
    ::nova::rabbit_*.

    Change-Id: Iab5b83478c33ca57a4612171df991c1927496f6f
    Closes-bug: 1401766
    (cherry picked from commit d2fa6cadafcf1445ea241a9051b4bdf35090a2db)

tags: added: in-stable-juno
Mathieu Gagné (mgagne)
Changed in puppet-nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.