Inkscape

[SVG font editor] Kerning tab broken

Bug #1406543 reported by jazzynico
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
su_v
Inkscape 0.92 "0.92"

Bug Description

Reproduced on Windows XP, Inkscape trunk rev. 13823 and 0.91.x rev. 13690.
Not reproduced with 0.48.5.

Steps:
1. Open the attached file.
2. Open the SVG font editor (Text>SVG Font Editor).
3. Select the Kerning tab
-> The pairs list is empty (2 pairs are defined in the SVG file)

Note that the console shows the following messages when loading the file:
** (inkscape.exe:624): WARNING **: unknown type: svg:hkern
** (inkscape.exe:624): WARNING **: unknown type: svg:hkern

Creating the font with Inkscape 0.91.x or 0.48.5 doesn't seem to change anything, and the pairs don't show in both cases.

See original description
Revision history for this message
jazzynico (jazzynico) wrote :
description: updated
Revision history for this message
jazzynico (jazzynico) wrote :

Related: Bug #1406540 "SVG fonts don't show when opening a file from a blank document" <https://bugs.launchpad.net/inkscape/+bug/1406540>

description: updated
Revision history for this message
jazzynico (jazzynico) wrote :

Also reproduced on Crunchbang Waldorf, Inkscape trunk rev.13828. The Kerning tab is completely unusable.

Changed in inkscape:
status: New → Confirmed
Revision history for this message
su_v (suv-lp) wrote :

Reproduced on OS X 10.7.5, Inkscape 0.91+devel r13829 (kerning tab unusable).

Note that earlier stable versions (using GTK+/X11) here crash when selecting one of the kerning pairs defined in 'font1' of the sample file. They also crash when trying to first add the second glyph 'b' to the text rendered in the preview area below the tabs. Tested with 0.48.5, 0.48.2, 0.47 on OS X 10.7.5.

Thus I can't verify whether what is broken in current trunk ever fully worked in a stable version with this SVG file (re regression). The crash seen on OS X with stable versions has likely been reported before.

su_v (suv-lp)
tags: added: svgfonts
removed: fonts
su_v (suv-lp)
Changed in inkscape:
milestone: none → 0.92
Revision history for this message
su_v (suv-lp) wrote :

Diff to add hkern and vkern to src/sp-factory.cpp: this makes them listed in the 'Kerning' tab again. Please review (I have no idea whether this is correct or not).

Note: The diff does not fix the crash described in comment #4 with the attached test case when selecting one of the listed kerning pairs (the crash also happens with Inkscape 0.48.5).

Revision history for this message
su_v (suv-lp) wrote :

Attaching screenshot of patched 0.91+devel r14224 on OS X 10.7.5 (X11-backend): the kerning tab works ok (including its own preview), using the svgfont demo from Inkscape's shared 'examples' directory.

AFAICT the crash mentioned in earlier comments seems to be triggered if a kerning pair is rendered in the preview area below, and is not a regression related to the C++ification in r12532 which broke the kerning tab (happens with earlier builds, too) -> should be tracked separately.

Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested successfully on Windows XP (32 bit) and Xubuntu 14.04 (64 bit) with Inkscape trunk rev. 14225.

Note that selecting the pairs or using the glyphs in the preview text zone doesn't cause a crash on my systems.

Changed in inkscape:
assignee: nobody → ~suv (suv-lp)
status: Confirmed → In Progress
tags: added: backport-proposed
Revision history for this message
su_v (suv-lp) wrote :

Fix committed to trunk in rev 14230.

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
su_v (suv-lp) wrote :

I failed to figure out an easy backport of rev 14230 to the stable release branch (0.91.x) - too much seems to have changed in trunk.

Removing 'backport-proposed' tag for now (if anyone happens to know how to do it - feel free to provide a patch, or to commit a backport to 0.91.x).

tags: removed: backport-proposed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.