puppet-nova

Add support for rabbimtq class false value for nova module

Bug #1407077 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
Undecided
Bogdan Dobrelya
puppet-cinder 6.0.0 "6.0.0"
puppet-nova
Fix Released
Undecided
Bogdan Dobrelya
puppet-nova 6.0.0 "6.0.0"

Bug Description

As long as we want puppet-nova only configure RabbitMQ users, vhosts and access rights, we have to make Nova::Rabbitmq class to be told to not install rabbitmq-server package and to not configure its service.

The related bug is https://bugs.launchpad.net/puppet-nova/+bug/1386309.
According to which puppet-nova should not support the newer versions of rabbitmq module. So, existing rabbitmq_class option should be used to skip any service configuration steps as well, if requested.

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

related https://bugs.launchpad.net/puppet-nova/+bug/1386309

Changed in puppet-nova:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144745

Changed in puppet-nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/144745
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=87be273bcf556c6cfa85e84104812b2581b307e0
Submitter: Jenkins
Branch: master

commit 87be273bcf556c6cfa85e84104812b2581b307e0
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Jan 2 13:44:33 2015 +0100

    Add an option to not configure RabbitMQ service.

    W/o this change we cannot drop a RabbitMQ service (cluster)
    installation and configuration from Nova module.
    We want Nova module to has an option to configure only users,
    rights, vhosts but not the AMQP cluster itself (this part
    should be moved to some other modules).

    The solution is:
    * add a False value for the rabbitmq_class parameter and skip
      all of the related configuration steps, if the False value
      was specified.
    * Deprecate rabbitmq_class parameter.

    Closes-bug: #1407077

    Change-Id: I31984e2ca1b2959d9e58c02db620f56931d38e7b
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in puppet-nova:
status: In Progress → Fix Committed
Bogdan Dobrelya (bogdando)
Changed in puppet-cinder:
assignee: nobody → Bogdan Dobrelya (bogdando)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147420

Changed in puppet-cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/147420
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=583e7c39c42f5d28bcc2e9eb94120917d248d40d
Submitter: Jenkins
Branch: master

commit 583e7c39c42f5d28bcc2e9eb94120917d248d40d
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Jan 15 09:33:54 2015 +0100

    Add an option to not configure RabbitMQ service.

    W/o this change we cannot drop a RabbitMQ service (cluster)
    installation and configuration from Cinder module.
    We want Cinder module to has an option to configure only users,
    rights, vhosts but not the AMQP cluster itself (this part
    should be moved to some other modules).

    The solution is:
    * add a False value for the rabbitmq_class parameter and skip
      all of the related configuration steps, if the False value
      was specified.
    * Deprecate rabbitmq_class parameter.

    Closes-bug: #1407077

    Change-Id: Ie13123f01fc4a2079dd7ef6622675b7e8c7f417e
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in puppet-cinder:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-nova:
milestone: none → 6.0.0
Changed in puppet-cinder:
milestone: none → 6.0.0
Matt Fischer (mfisch)
Changed in puppet-cinder:
status: Fix Committed → Fix Released
Changed in puppet-nova:
status: Fix Committed → Fix Released
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Released → Fix Committed
Changed in puppet-nova:
status: Fix Released → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Committed → Fix Released
Changed in puppet-nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.