OpenStack DBaaS (Trove)

When trying to deploy a cluster for specific datastore and it's missing, Trove raises HTTP 400 instead of HTTP 404 (NotFound)

Bug #1415031 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Ashleigh Farnham
OpenStack DBaaS (Trove) 2015.1.0 "kilo"

Bug Description

When trying to deploy a cluster for specific datastore and it's missing, Trove raises HTTP 400 instead of HTTP 404 (NotFound)

trove cluster-create test_cluster cassandra 2.1.2 --instance flavor_id=2,volume=2,type=seed_node --instance flavor_id=2,volume=2,type=data_node
ERROR: Datastore 'cassandra' cannot be found. (HTTP 400)

Ashleigh Farnham (ashleighfarnham-deactivatedaccount)
Changed in trove:
assignee: nobody → Ashleigh Farnham (ashleigh-farnham)
Ashleigh Farnham (ashleighfarnham-deactivatedaccount)
Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151055

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/151055
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=54fa006ea2ed5568b276a176c078bc782da58473
Submitter: Jenkins
Branch: master

commit 54fa006ea2ed5568b276a176c078bc782da58473
Author: Ashleigh Farnham <email address hidden>
Date: Wed Jan 28 15:32:07 2015 -0800

    Update DatastoreNotFound status code to 404

    Explicitly specifying DatastoreNotFound exception to return http
    status code 404. Previously we weren't specifying the status code
    for the exception and were returning 400 by default. The unit test
    depending on the previous status code has been updated to reflect
    this change.

    Closes-Bug: 1415031
    Change-Id: I30bd97d53d1d51704133eb63e25f32a20cf0d9a1

Changed in trove:
status: In Progress → Fix Committed
Nikhil Manchanda (slicknik)
Changed in trove:
milestone: none → kilo-2
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.