Update command for nonexistent element works different for different Mistral items

Bug #1418545 reported by Anastasia Kuznetsova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Low
Limor Stotland
Liberty
Fix Released
Low
Limor Stotland

Bug Description

Need to be consistent in implementation of update method.
For example if we take a look at workflows, we will see that we can execute workflow-update if there is no such wf, it will be created:
https://github.com/stackforge/mistral/blob/ece3e75d32adce96a3bc56994fdee0c083494aad/mistral/services/workflows.py#L54

Another situation with workbooks and environments:
https://github.com/stackforge/mistral/blob/ece3e75d32adce96a3bc56994fdee0c083494aad/mistral/services/workbooks.py#L60
https://github.com/stackforge/mistral/blob/914a7bbe6b10d2d4da8b69d1e3c627d5f445c609/mistral/api/controllers/v2/environment.py#L137

Changed in mistral:
importance: Undecided → Low
milestone: none → kilo-3
status: New → Incomplete
status: Incomplete → New
no longer affects: mistral/kilo
Changed in mistral:
assignee: nobody → Limor Stotland (limor-bortman)
Changed in mistral:
status: New → In Progress
Revision history for this message
Limor Stotland (limor-bortman) wrote :

I propose a fix but for some reason it's not connect to the bug :
https://review.openstack.org/#/c/201228/

description: updated
description: updated
Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

Limor, the comment will be added once the patch has been merged in.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/201228
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=856d1d7154146856e05f66a909fbea6014d0aaa5
Submitter: Jenkins
Branch: master

commit 856d1d7154146856e05f66a909fbea6014d0aaa5
Author: Limor Stotland <email address hidden>
Date: Mon Jul 13 15:37:01 2015 +0000

    Make update behavior consistent

    Keep behavior of updating workflow consistent with that of workbook and
    environment. The update command will fail if the workflow doesn't exist.

    Change-Id: I7a871c2ac378ac0b7f6360f03f395816b9d0f4b0
    Closes-Bug: #1418545

Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
milestone: 1.0.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.