[UI] Remove css from templates

Bug #1421287 reported by Chad Roberts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Low
Unassigned
Sahara
Fix Released
Low
Mikhail

Bug Description

* low priority, technical debt item *

There are a couple places in the Data Processing panels where there is css defined inside of the templates. Ideally, existing css rules can be applied to achieve the desired results, but it is possible that we may need to add new styles to the projects css definitions.

The places where css is defined in data processing templates are:
.../horizon/openstack_dashboard/dashboards/project/data_processing/job_binaries/templates/data_processing.job_binaries/job_binaries.html

<style type="text/css">
  #id_job_binary_url {
    width: 200px !important; }
  .form-help-block {
    float: left;
    text-align: left;
    width: 300px; }
</style>

and

.../horizon/openstack_dashboard/dashboards/project/data_processing/jobs/templates/data_processing.jobs/jobs.html

<style type="text/css">
    .job_origin_main, .job_origin_lib {
    width: 200px !important; }
    .job_binary_add_button, .job_binary_remove_button {
    width: 80px !important;
    margin-left: 5px; }
    .form-help-block {
    float: left;
    text-align: left;
    width: 300px; }
    .lib-input-div {
    float:left;
    width:320px; }
    .job-libs-display {
    float:left; }
    .actions_column {
    width: 210px !important; }
</style>

Tags: dashboard
Changed in horizon:
assignee: nobody → Nikunj Aggarwal (nikunj2512)
Changed in horizon:
importance: Undecided → Low
status: New → Confirmed
Changed in horizon:
assignee: Nikunj Aggarwal (nikunj2512) → Gal (galmargalit)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Gal Margalit (galmargalit) wrote :

Waiting for code review

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Gal Margalit (<email address hidden>) on branch: master
Review: https://review.openstack.org/197051

Changed in horizon:
assignee: Gal Margalit (galmargalit) → nobody
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote : Re: [data processing] Remove css from templates

Sahara now resides in its own dashboard repo; adding Sahara to bug tracker

Changed in horizon:
status: In Progress → Invalid
Changed in sahara:
status: New → Confirmed
summary: - [data processing] Remove css from templates
+ [UI] Remove css from templates
Changed in sahara:
importance: Undecided → Low
tags: added: dashboard
removed: sahara
Mikhail (mlelyakin)
Changed in sahara:
assignee: nobody → Mikhail (mlelyakin)
Changed in sahara:
milestone: none → newton-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/362033

Changed in sahara:
status: Confirmed → In Progress
Changed in sahara:
milestone: newton-3 → newton-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (master)

Reviewed: https://review.openstack.org/362033
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=2b900b5a93cd3269e9a098249beb05986d6e32cf
Submitter: Jenkins
Branch: master

commit 2b900b5a93cd3269e9a098249beb05986d6e32cf
Author: Mikhail Lelyakin <email address hidden>
Date: Thu Sep 1 14:05:29 2016 +0300

    Remove css styles from html templates

    Changes:
      1. Remove css styles from html templates.
      2. Transfer this styles to new css files.

    Change-Id: I318b5fb4a6f15456d7756bc438e0d93b91255203
    Closes-bug: 1421287

Changed in sahara:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara-dashboard 5.0.0.0rc1

This issue was fixed in the openstack/sahara-dashboard 5.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.