Fuel for OpenStack

[astute] unexpected erasing nodes during Image based provision

Bug #1427718 reported by Vladimir Sharshov
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vladimir Sharshov
Fuel for OpenStack 6.1-updates
5.1.x
Won't Fix
High
Michal Rostecki
Fuel for OpenStack 5.1.1-updates
6.0.x
Won't Fix
High
Michal Rostecki
Fuel for OpenStack 6.0-updates

Bug Description

After short meeting with Vladimir Kozhukalov i got info about bug in Astute and way to solve. The main problem is here: https://github.com/stackforge/fuel-astute/blob/master/lib/astute/orchestrator.rb#L181

Provisioned nodes by image based provision can answer to mcollective about wrong type and erased.

Vladimir Sharshov (vsharshov)
Changed in fuel:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/160891

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (master)

Reviewed: https://review.openstack.org/160891
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=47b738431ed87af314d0477625a18cdd258a0148
Submitter: Jenkins
Branch: master

commit 47b738431ed87af314d0477625a18cdd258a0148
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Mar 3 19:57:56 2015 +0300

    Prevent unexpected erasing nodes during image based provision

    Classic provisioning flow:

    bootstrap -> erase -> reboot -> provisioning (node do not respond via mcollective) -> reboot -> target

    If system is backed online via mcollective and return bootstrap status, it will be erased.

    Image flow before this change:

    bootstrap -> erase -> provisioning (node still can respond via mcollective) -> reboot -> target

    Sometimes we can ask nodes about status in case of image flow
    before they will be rebooted. And send them to erase if they are answered 'bootstrap'. To prevent such situation, we add
    new systemtype 'image'.

    Now workflow will be looked:

    bootstrap -> erase -> image -> provisioning (node still can respond via mcollective) -> reboot -> target

    We marked nodes with 'image' systemtype as not provisioned, but do not try to erase them.

    This new type should not block any other operations with node:

    * delete;
    * stop provisioning;
    * reprovisioning.

    Change-Id: I7fcc32c604526575d7805386ecfe3d0d40cbd12e
    Closes-Bug: #1427718

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (stable/5.1)

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/220373

Michal Rostecki (mrostecki)
tags: added: customer-found
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (stable/6.0)

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/221154

Revision history for this message
Michal Rostecki (mrostecki) wrote :

Backports to 5.1 and 6.0 are needed - there are problems with provisioning new nodes in these versions which can be fixed only by the following patches.

Michal Rostecki (mrostecki)
Changed in fuel:
milestone: 6.1 → 5.1.2
milestone: 5.1.2 → 6.1-updates
milestone: 6.1-updates → none
Michal Rostecki (mrostecki)
no longer affects: fuel/6.1.x
Roman Rufanov (rrufanov)
tags: added: support
Changed in fuel:
milestone: none → 6.1-updates
Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

Won't Fix for 5.1.1-updates and 6.0-updates - there is no way to deliver astute fixes for 5.1.1 and 6.0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-astute (stable/5.1)

Change abandoned by Michal Rostecki (<email address hidden>) on branch: stable/5.1
Review: https://review.openstack.org/220373

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-astute (stable/6.0)

Change abandoned by Michal Rostecki (<email address hidden>) on branch: stable/6.0
Review: https://review.openstack.org/221154

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.