puppet-neutron

neutron l3_ha cannot be disabled once enabled

Bug #1431635 reported by Sean Lynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-neutron
Fix Released
Medium
Gael Chamoulaud
puppet-neutron 6.0.0 "6.0.0"

Bug Description

By default the value of l3_ha in server.pp is set to False. However, once the value is initially set to True, resetting to False does not change the value in neutron.conf.

--Snip--
  if $l3_ha {
    if $min_l3_agents_per_router <= $max_l3_agents_per_router or $max_l3_agents_per_router == '0' {
      neutron_config {
        'DEFAULT/l3_ha': value => true;
        'DEFAULT/max_l3_agents_per_router': value => $max_l3_agents_per_router;
        'DEFAULT/min_l3_agents_per_router': value => $min_l3_agents_per_router;
        'DEFAULT/l3_ha_net_cidr': value => $l3_ha_net_cidr;
      }
    } else {
      fail('min_l3_agents_per_router should be less than or equal to max_l3_agents_per_router.')
    }
  }
--Snip--

missing else statement here

Sean Lynn (trad511)
Changed in puppet-neutron:
assignee: nobody → Sean Lynn (trad511)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164041

Changed in puppet-neutron:
status: New → In Progress
Emilien Macchi (emilienm)
Changed in puppet-neutron:
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in puppet-neutron:
assignee: Sean Lynn (trad511) → Gael Chamoulaud (gael-chamoulaud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (master)

Reviewed: https://review.openstack.org/164041
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=f3fd385bf452f32969b03224f7a46dea90b735cc
Submitter: Jenkins
Branch: master

commit f3fd385bf452f32969b03224f7a46dea90b735cc
Author: Sean Lynn <email address hidden>
Date: Thu Mar 12 18:31:10 2015 -0600

    Allow l3_ha to be disabled

    By default l3_ha is turned off. Allow l3_ha to be turned back off
    after it has been enabled.

    Change-Id: I65022e62736fa955c9b898331ccc70b5b2d8b7f6
    Closes-Bug: 1431635

Changed in puppet-neutron:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-neutron:
milestone: none → 6.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187389

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (stable/juno)

Reviewed: https://review.openstack.org/187389
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=695940bc91207c6062bc47a52850aa389371beaf
Submitter: Jenkins
Branch: stable/juno

commit 695940bc91207c6062bc47a52850aa389371beaf
Author: Sean Lynn <email address hidden>
Date: Thu Mar 12 18:31:10 2015 -0600

    Allow l3_ha to be disabled

    By default l3_ha is turned off. Allow l3_ha to be turned back off
    after it has been enabled.

    Change-Id: I65022e62736fa955c9b898331ccc70b5b2d8b7f6
    Closes-Bug: 1431635
    (cherry picked from commit f3fd385bf452f32969b03224f7a46dea90b735cc)

tags: added: in-stable-juno
Mathieu Gagné (mgagne)
Changed in puppet-neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.