SIP AQ (permenent location) not honoring location change on floating copy checkin

Bug #1438252 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.7
Fix Released
Medium
Unassigned
2.8
Fix Released
Undecided
Unassigned

Bug Description

Evergreen master circa 2.8; likely affects all versions.

The SIP AQ Permanent Location field is used to tell where a copy should be delivered if it's not otherwise in transit. The AQ value returned by the Evergreen SIP module during checkin matches the circ_lib of the copy *before* the checkin occurs. This is normally fine, but if the copy is floating, the checkin will modify the circ_lib of the copy. The SIP code needs to report the updated circ_lib information after the checkin occurs.

Patch in progress...

Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1438252-sip-floating-checkin-loc

To test in concerto:

1. evergreen# update asset.copy set floating = 1 where id = 107;

2. Check in copy CONC50000142 via SIP at a location that's not BR2. The AQ field should show the checkin branch and not the original circ_lib of BR2.

Beware checkin of copies that are captured for holds, since the circ_lib of such copies is not modified even if they are floating.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.8.0
Bill Erickson (berick)
Changed in evergreen:
milestone: 2.8.0 → 2.8.1
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
milestone: 2.8.1 → 2.8.3
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Bill Erickson (berick) wrote :

We're running this patch in production. Floating copies now sort to correct destination bins.

Changed in evergreen:
milestone: 2.8.3 → 2.9-alpha
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Revision history for this message
Ben Shum (bshum) wrote :

Picked to master and backported to rel_2_8 and rel_2_7. Thanks Bill!

Changed in evergreen:
status: Triaged → Fix Committed
no longer affects: evergreen/2.6
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.