MAAS

Releasing node not transitioned to "Failed releasing"

Bug #1438606 reported by Raphaël Badin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Raphaël Badin
MAAS 1.8.0

Bug Description

A node with a faulty BMC was being released and, although I saw a message like "normal-money.local: Power could not be turned off; timed out." in the log, the node didn't get transitioned to "Failed releasing".

Tags: twisted

Related branches

lp://qastaging/~rvb/maas/failed-releasing-bug-1438606
Raphaël Badin (community): Approve
Gavin Panella (community): Approve
Diff: 37 lines (+9/-0)
2 files modified
src/provisioningserver/rpc/power.py (+2/-0)
src/provisioningserver/rpc/tests/test_power.py (+7/-0)
Revision history for this message
Raphaël Badin (rvb) wrote :

I believe this happens because, in src/provisioningserver/rpc/power.py, 'maybe_change_power_state' call 'change_power_state' via 'deferWithTimeout' and when the cancellation happens, no call to 'power_change_failure' is made.

Andres Rodriguez (andreserl)
Changed in maas:
milestone: none → 1.8.0
Revision history for this message
Gavin Panella (allenap) wrote :

After the call to deferLater() in maybe_change_power_state(), *before* adding the final errback to log.err, an errback that traps CancelledError ought to be added. That can log and call power_change_failure().

Raphaël Badin (rvb)
Changed in maas:
assignee: nobody → Raphaël Badin (rvb)
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.