changing node name on node details weirdness

Bug #1439356 reported by Carla Berkers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Medium
Unassigned

Bug Description

If I click on the name of ariel.maas to edit it, the field becomes editable and the name changes to ariel.local.

If I change "Ariel" it switches back to [newname].maas when I click save.

If I change the "maas" part it doesn't update on node details or the listing when I click save.
When I click the field again though the new name reappears.

For sure a node can't change name when I click to edit.
Not sure if I should be able to edit the second part of the node name at all?

Tags: ui

Related branches

Revision history for this message
Andres Rodriguez (andreserl) wrote :

What version are you running?

Revision history for this message
Blake Rouse (blake-rouse) wrote :

This is trunk and you are correct. MAAS will create all nodes that are enlisted with a ".local" domain in the hostname. When you click to edit the hostname the fqdn of the node is changes to just the hostname, as that is all you can edit on the node. The domain section of the node comes from the cluster that the node belongs to, so you cannot change this here.

Now there is no way I can change this behavior in the UI as this is just the nature of how this needs to be done. The only thing that we can change is the backend. We can remove the use of ".local" when the node is added. I really don't understand it any way, is it there for a reason? Can we remove it safely and only allow the hostname.

Now if we do change the backend you still will have this issue, because when you click the name of the node, the domain of the cluster will disappear because you cannot edit it on that page. We might be able to only wrap the first part of the hostname in the span, so you can only click the hostname and not the full fqdn. Again this requires the background change as I described above.

Revision history for this message
Carla Berkers (carlaberkers) wrote :

Yes in trunk, thanks Blake!

Actually at the moment, if I click to edit the domain looks editable too because it is also displayed in the form field. Point of the bug was short term - can we just display the hostname not the fqdn in the edit field to avoid confusion?

Long term I am for removing it all together as well, don't think it makes sense. Domain is valiable info but doesnt have to be part of the hostname (as far as I can tell :-)) There is a use case for it though, I believe in OIL for instance they use it to see what chassis a node is a part of (host1.seamicro1 or host8.seamicro2).

So when we make backend changes we should allow filter by cluster on node listing.

Changed in maas:
importance: Undecided → Medium
milestone: none → 1.8.0
status: New → Triaged
Revision history for this message
Blake Rouse (blake-rouse) wrote :

So this is related to bug 1452154. Which we cannot just change all the nodes hostnames as it will break peoples installations on upgrade. What this bug will do is no longer add this information by default.

This weirdness will still exist on older installations, but once they remove the .local from the hostname the weirdness will go away. The validation on the node details page already prevents them from having a .local in the hostname.

Once bug 1452154 is fixed this will be marked fixed as well. Only because the weirdness can never go away until all users have removed the .local from the hostnames of the nodes.

Changed in maas:
status: Triaged → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.