Cinder

Make sure self.assertEqual in test_volume.py has the correct param order

Bug #1441964 reported by Vincent Hou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Vincent Hou
Cinder 7.0.0 "liberty"

Bug Description

self.assertEqual in test_volume.py is supposed to have (expected, result) as the parameters. However, some code did it in a reverse way. Need to correct them.

Vincent Hou (houshengbo)
Changed in cinder:
assignee: nobody → Vincent Hou (houshengbo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171929

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/171929
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ad60252fa0cb845998d9e7bc9b9806589ba81a29
Submitter: Jenkins
Branch: master

commit ad60252fa0cb845998d9e7bc9b9806589ba81a29
Author: Vincent Hou <email address hidden>
Date: Thu Apr 9 13:43:17 2015 +0800

    Fix assertEqual in test_volume.py in correct order of params

    AssertEqual/assertDictMatch is called with the wrong order of
    parameters in many parts of test_volume.py. This patch fix them
    all for test_volume.py.

    Change-Id: I2ffb3a928710eb22eac9fc3afb6c2e38dc9903ce
    Closes-bug: #1441964

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.