We should use @morris.signal to avoid clashing with the signal module
Bug #1442175 reported by
Zygmunt Krynicki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| PlainBox (Toolkit) |
Fix Released
|
Medium
|
Zygmunt Krynicki | ||
Bug Description
In all the code where we use @signal as a morris-signal decorator we should change that to read @morris.signal so that we don't have to import 'signal' as a top-level variable. This will prevent accidental shadowing of the standard library signal module.
Related branches
lp://qastaging/~zyga/checkbox/fix-1442175
- Maciej Kisielewski (community): Approve
-
Diff: 247 lines (+30/-27)6 files modifiedplainbox/plainbox/impl/ctrl.py (+2/-2)
plainbox/plainbox/impl/pod.py (+2/-2)
plainbox/plainbox/impl/result.py (+3/-3)
plainbox/plainbox/impl/runner.py (+3/-3)
plainbox/plainbox/impl/session/manager.py (+3/-3)
plainbox/plainbox/impl/session/state.py (+17/-14)
| Changed in plainbox: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in plainbox: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Zygmunt Krynicki (zyga) |
| Changed in plainbox: | |
| milestone: | none → 0.21 |
| Changed in plainbox: | |
| status: | In Progress → Fix Committed |
| Changed in plainbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
