Fuel for OpenStack

Processes in namespeces are not killed during DHCP/L3 agent restart

Bug #1442251 reported by Sergey Kolekonov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Kolekonov
Fuel for OpenStack 6.1
6.0.x
Fix Released
High
Alexander Nevenchannyy
Fuel for OpenStack 6.0-mu-4

Bug Description

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  api: "1.0"
  build_number: "282"
  build_id: "2015-04-06_08-49-30"
  nailgun_sha: "a2dc04af9c5838a990adeab81789d4c090943701"
  python-fuelclient_sha: "9ad42671130deb2cc81135fb453ef0793883be2c"
  astute_sha: "240bfefe0a0b5af21b79854d0c96d8a3ee0fd885"
  fuellib_sha: "601cc8e1dccbdcf328f83f071270609e824d6c5a"
  ostf_sha: "b978badb43243d3f1b85dde15b8e301a21f12254"
  fuelmain_sha: "f90d7d40ceff39ee6d7587b183c63bd00ed0743f"

When p_neutron-dhcp-agent agent resource is stopped, dnsmasq processes are not killed as it's supposed in OCF script.
The problem is in OCF script which kills only processes in the first found namespace.
The same problem exists for L3 agent OCF script (and ns-metadata processes)

See original description
Sergey Kolekonov (skolekonov)
summary: - dnsmasq processes are not removed during DHCP agent restart
+ dnsmasq processes are not killed during DHCP agent restart
Aleksey Kasatkin (alekseyk-ru)
Changed in fuel:
assignee: nobody → Fuel Library Team (fuel-library)
Sergey Kolekonov (skolekonov)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Sergey Kolekonov (skolekonov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/172145

Changed in fuel:
status: New → In Progress
Ivan Berezovskiy (iberezovskiy)
Changed in fuel:
importance: Undecided → High
milestone: none → 6.1
Sergey Kolekonov (skolekonov)
summary: - dnsmasq processes are not killed during DHCP agent restart
+ Processes in namespeces are not killed during DHCP/L3 agent restart
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/172145
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d3816fe2ba3e5fa020e6a57bb58a23352cadd5ac
Submitter: Jenkins
Branch: master

commit d3816fe2ba3e5fa020e6a57bb58a23352cadd5ac
Author: Sergey Kolekonov <email address hidden>
Date: Thu Apr 9 19:38:39 2015 +0300

    Properly kill processes in namespaces on DHCP/L3 agent stop/start

    get_pid_list_for_ns_list function uses namespaces list as an argument.
    Variable $ns_list is a string of namespaces divided by spaces.
    To properly use all of its values we need to use all arguments ($@).

    Change-Id: I32654bf7e537247f97070ed27ab8d7b4de5b35c7
    Closes-bug: #1442251

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Kristina Berezovskaia (kkuznetsova) wrote :

Verify:

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "432"
  build_id: "2015-05-18_03-43-53"
  nailgun_sha: "076566b5df37f681c3fd5b139c966d680d81e0a5"
  python-fuelclient_sha: "38765563e1a7f14f45201fd47cf507393ff5d673"
  astute_sha: "cb655a9a9ad26848bcd9d9ace91857b6f4a0ec15"
  fuel-library_sha: "1621cb350af744f497c35f2b3bb889c2041465d8"
  fuel-ostf_sha: "9ce1800749081780b8b2a4a7eab6586583ffaf33"
  fuelmain_sha: "0e970647a83d9a7d336c4cc253606d4dd0d59a60"

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/6.0)

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/191883

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/6.0)

Reviewed: https://review.openstack.org/191883
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3f0a3c80b616a69985a9a51ecf5466a7d37c2312
Submitter: Jenkins
Branch: stable/6.0

commit 3f0a3c80b616a69985a9a51ecf5466a7d37c2312
Author: Sergey Kolekonov <email address hidden>
Date: Thu Apr 9 19:38:39 2015 +0300

    Properly kill processes in namespaces on DHCP/L3 agent stop/start

    get_pid_list_for_ns_list function uses namespaces list as an argument.
    Variable $ns_list is a string of namespaces divided by spaces.
    To properly use all of its values we need to use all arguments ($@).

    Closes-bug: #1442251

    Conflicts:
     deployment/puppet/cluster/files/ocf/neutron-agent-dhcp
     deployment/puppet/cluster/files/ocf/neutron-agent-l3

    Change-Id: I32654bf7e537247f97070ed27ab8d7b4de5b35c7

Revision history for this message
Andrew Woodward (xarses) wrote :

customer found on 5.1, please backport

Roman Rufanov (rrufanov)
tags: added: customer-found support
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.