clear hold shelf checkin modifier use during checkin broken in 2.8

Bug #1444130 reported by Ben Shum
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

Evergreen master / 2.8

When using the clear hold shelf checkin modifier on checkin of items, users would get a network error and would not be able to process those items. The error would look like:

Call to [open-ils.circ.checkin] failed for session ... thread trace [1]:\nCan't locate object method \"max_chunk_size\" via package \"OpenSRF::AppSubrequest\" at /usr/local/share/perl/5.14.2/Op​enILS/Application/Circ/Holds.pm line 3630.

This occurs because of changes to Holds.pm in this commit: http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4ccbf980e1f2eadf9f99e015e7ac3d4765d046f2

After some investigation in IRC, a solution was found by changing line 3630 from:

$client->max_chunk_size($chunk_size);

to:

$client->max_chunk_size($chunk_size) if ($client->can('max_chunk_size'));

Working branch forthcoming, along with some other safeguarding of other parts of Holds.pm that were also changed (but may not be broken in the same way).

Tags: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.8.1
importance: Undecided → High
status: New → Triaged
Changed in evergreen:
status: Triaged → Confirmed
Revision history for this message
Jason Stephenson (jstephenson) wrote :
tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Works as expected. Merged to 2.8+. Thanks, Jason.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.