puppet-swift

Unneeded dependency on ssh?

Bug #1447259 reported by Javier Peña
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Medium
Javier Peña
puppet-swift 6.0.0 "6.0.0"

Bug Description

puppet-swift requires saz/ssh, and includes ::ssh::server in manifests/init.pp. This does not seem to be required, and causes certain side effects, such as having the ssh module manage /etc/ssh/ssd_config, which may not be desired. Only manifests/init.pp makes any use of the ssh module, with no references anywhere else.

Is there any reason to keep this dependency, or could it be removed?

Revision history for this message
Richard Raseley (richard-raseley) wrote :

I agree that this module should not be managing SSH.

I'd be happy to prepare a patch to fix this. It shouldn't take more than a few minutes.

Before that, I would be interested to see if anyone else has historical context as to why this came to be.

Changed in puppet-swift:
status: New → Confirmed
Revision history for this message
Richard Raseley (richard-raseley) wrote :

So, to add a little bit more context. I am guessing that we are trying to manage SSH because we depend upon it in order to ship the ring files around.

On a philosophical level, I feel that SSH is such a low-level service that it is reasonable to just assume (or direct that it be) in place prior to configuring Swift.

It would be far more surprising for an operator to have their SSH configs modified unexpectedly, than to have runs fail because SSH is not configured.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/176432

Changed in puppet-swift:
assignee: nobody → Richard Raseley (richard-raseley)
status: Confirmed → In Progress
Revision history for this message
Richard Raseley (richard-raseley) wrote :

Here is a fix that can be merged, should others agree:

https://bugs.launchpad.net/puppet-swift/+bug/1447259

Emilien Macchi (emilienm)
Changed in puppet-swift:
importance: Undecided → Medium
status: In Progress → Triaged
Revision history for this message
Richard Raseley (richard-raseley) wrote :

Sorry, link should have been:

https://review.openstack.org/176432

OpenStack Infra (hudson-openstack)
Changed in puppet-swift:
status: Triaged → In Progress
OpenStack Infra (hudson-openstack)
Changed in puppet-swift:
assignee: Richard Raseley (richard-raseley) → Javier Peña (jpena-c)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/176432
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=00d10f1c3ebd8103cf256259397ad74b5af0818a
Submitter: Jenkins
Branch: master

commit 00d10f1c3ebd8103cf256259397ad74b5af0818a
Author: Richard Raseley <email address hidden>
Date: Wed Apr 22 11:37:31 2015 -0700

    Removal of SSH Components

    This change removes all SSH-related components, their configuration
    options, and tests.

    SSH is such a low-level service (from the perspective of any operator
    deploying a cloud), that it is reasonable to assume that (or provide
    direction that) SSH must be installed and configured prior to usage of
    the puppet-swift module.

    Without this change, there is a significant liklihood of confusion
    occurring in the likely case of SSH being managed elsewhere.

    Change-Id: I0f695788b2784669a3fb285e4bedf0159c4cb89a
    Closes-Bug: 1447259

Changed in puppet-swift:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-swift:
milestone: none → 6.0.0
Mathieu Gagné (mgagne)
Changed in puppet-swift:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.