OpenStack Heat

ValueError is not standardized raise in API

Bug #1449349 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua
OpenStack Heat 5.0.0 "liberty"

Bug Description

There are some APIs will raise ValueError exception, this is not standardized, I believe we should use HTTPBadRequest instead.

huangtianhua (huangtianhua)
Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/178494

Changed in heat:
status: New → In Progress
Steve Baker (steve-stevebaker)
Changed in heat:
importance: Undecided → High
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/178494
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=767696fc472d72666300531f5cdc5c66059e2969
Submitter: Jenkins
Branch: master

commit 767696fc472d72666300531f5cdc5c66059e2969
Author: huangtianhua <email address hidden>
Date: Wed Apr 29 11:25:35 2015 +0800

    Raise HTTPBadRequest instead of ValueError for API validation

    Raise HTTPBadRequest exception instead of ValueError for
    parameters validation.

    Change-Id: I468181930299353908a53a3a940ff843d8547bde
    Closes-Bug: #1449349

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.