HDS HNAS Driver fails when FS unhealthy

Bug #1452002 reported by Erlon R. Cruz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Adriano
Kilo
Fix Released
Low
Adriano

Bug Description

If the storage admin removes a file system and this file system get into an unhealthy state, the driver code fails as its parser does not handle the output generated in this case.

-------------------------------------------------
ERROR cinder.volume.manager [req-3038eb01-8464-4d47-b4d3-9365632534ed None None] list index out of range
2015-05-05 11:36:03.009 TRACE cinder.volume.manager Traceback (most recent call last):
2015-05-05 11:36:03.009 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 302, in init_host
2015-05-05 11:36:03.009 TRACE cinder.volume.manager self.driver.do_setup(ctxt)
2015-05-05 11:36:03.009 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2015-05-05 11:36:03.009 TRACE cinder.volume.manager return f(*args, **kwargs)
2015-05-05 11:36:03.009 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/hds/iscsi.py", line 388, in do_setup
2015-05-05 11:36:03.009 TRACE cinder.volume.manager self._check_hdp_list()
2015-05-05 11:36:03.009 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/hds/iscsi.py", line 350, in _check_hdp_list
2015-05-05 11:36:03.009 TRACE cinder.volume.manager hdpl = self._get_hdp_list()
2015-05-05 11:36:03.009 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/hds/iscsi.py", line 326, in _get_hdp_list
2015-05-05 11:36:03.009 TRACE cinder.volume.manager self.config['password'])
2015-05-05 11:36:03.009 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/hds/hnas_backend.py", line 195, in get_hdp_info
2015-05-05 11:36:03.009 TRACE cinder.volume.manager (used, perstr) = (inf[5], inf[7])
2015-05-05 11:36:03.009 TRACE cinder.volume.manager IndexError: list index out of range
2015-05-05 11:36:03.009 TRACE cinder.volume.manager

Tags: drivers hds
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180300

Changed in cinder:
assignee: nobody → Adriano (rosso-af)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/180300
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=418cf4b989c8df983c1109c8c8851d9d4c3ffbfe
Submitter: Jenkins
Branch: master

commit 418cf4b989c8df983c1109c8c8851d9d4c3ffbfe
Author: Adriano Rosso <email address hidden>
Date: Tue May 5 15:58:38 2015 -0300

    HDS HNAS Driver fails when FS unhealthy

    This patch fixes the error when there is a file system in an
    unhealthy HNAS storage pool.

    Change-Id: Ic17c540039996f4a1060829d5f1f12a5f3155271
    Closes-bug: #1452002

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/180723

Mike Perez (thingee)
Changed in cinder:
milestone: none → liberty-1
importance: Undecided → Low
tags: added: drivers hds
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/kilo)

Reviewed: https://review.openstack.org/180723
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dabbaeda979dd441fc8376a63ec6d5d232656eff
Submitter: Jenkins
Branch: stable/kilo

commit dabbaeda979dd441fc8376a63ec6d5d232656eff
Author: Adriano Rosso <email address hidden>
Date: Tue May 5 15:58:38 2015 -0300

    HDS HNAS Driver fails when FS unhealthy

    This patch fixes the error when there is a file system in an
    unhealthy HNAS storage pool.

    Change-Id: Ic17c540039996f4a1060829d5f1f12a5f3155271
    Closes-bug: #1452002
    (cherry picked from commit 418cf4b989c8df983c1109c8c8851d9d4c3ffbfe)

Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.