puppet-glance

db_sync should be executed based on sync_db but not enabled nor manage_service

Bug #1452278 reported by Giulio Fidente
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
Undecided
Jiří Stránský
puppet-cinder 6.0.0 "6.0.0"
puppet-glance
Fix Released
Medium
Giulio Fidente
puppet-glance 6.0.0 "6.0.0"
puppet-keystone
Fix Released
Medium
Giulio Fidente
puppet-keystone 6.0.0 "6.0.0"

Bug Description

The db_sync command should be executed even though the api/registry classes are called with both (or one of) enabled and manage_service set to false.

It seems valid to assume that the enabled param should only deal with the service being enabled or not on boot (service>enable) and the manage_service param should only set the ensure state (service>ensure)

Emilien Macchi (emilienm)
Changed in puppet-glance:
status: New → Confirmed
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in puppet-glance:
assignee: nobody → Giulio Fidente (gfidente)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180565

Changed in puppet-keystone:
assignee: nobody → Giulio Fidente (gfidente)
status: New → In Progress
Emilien Macchi (emilienm)
Changed in puppet-keystone:
importance: Undecided → Medium
Jiří Stránský (jistr)
Changed in puppet-cinder:
assignee: nobody → Jiří Stránský (jistr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180610

Changed in puppet-cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/180610
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=ffdd9836bd52546e712a8b814d1ededd9a0f1c84
Submitter: Jenkins
Branch: master

commit ffdd9836bd52546e712a8b814d1ededd9a0f1c84
Author: Jiri Stransky <email address hidden>
Date: Wed May 6 18:12:17 2015 +0200

    Decouple $sync_db from $enabled

    Having to set both $enabled and $sync_db to true for the DB sync to
    happen breaks use cases when the service should stay completely
    unmanaged (not enabled, not started), but DB sync should still happen.
    For versatility of the module, the $enabled and $sync_db conditions
    should be decoupled.

    Change-Id: I2a0a76b54ebedba1ec098b8c64bd8e9684ed3099
    Closes-Bug: #1452278

Changed in puppet-cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/180229
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=c76d39605ff311eaba6ca226ac7dac19f86279ed
Submitter: Jenkins
Branch: master

commit c76d39605ff311eaba6ca226ac7dac19f86279ed
Author: Giulio Fidente <email address hidden>
Date: Wed May 6 13:29:19 2015 +0200

    Decouple sync_db from manage_service and enabled

    We want db_sync to run even though manage_service or enabled
    can be set to False.

    Change-Id: Ic3472ce6a6e704a2fa035df6e1c8866b8ea6bcbc
    Closes-Bug: 1452278

Changed in puppet-glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/180565
Committed: https://git.openstack.org/cgit/stackforge/puppet-keystone/commit/?id=3c08645ba8b894d3adce3d65464dd43a0a33ce55
Submitter: Jenkins
Branch: master

commit 3c08645ba8b894d3adce3d65464dd43a0a33ce55
Author: Giulio Fidente <email address hidden>
Date: Wed May 6 16:32:05 2015 +0200

    Decouple sync_db from enabled

    We want db_sync to run even though enabled can be set to False.

    Change-Id: I6eb3d137173d2542a8083bbca3acf3bee10c5919
    Closes-Bug: 1452278

Changed in puppet-keystone:
status: In Progress → Fix Committed
Matt Fischer (mfisch)
Changed in puppet-keystone:
milestone: none → 6.0.0
status: Fix Committed → Fix Released
Changed in puppet-glance:
milestone: none → 6.0.0
Changed in puppet-cinder:
milestone: none → 6.0.0
status: Fix Committed → Fix Released
Changed in puppet-glance:
status: Fix Committed → Fix Released
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Released → Fix Committed
Changed in puppet-glance:
status: Fix Released → Fix Committed
Changed in puppet-keystone:
status: Fix Released → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-keystone:
status: Fix Committed → Fix Released
Changed in puppet-glance:
status: Fix Committed → Fix Released
Changed in puppet-cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.