1.8b4 add extra NIC styling
Bug #1454355 reported by
Carla Berkers
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Richard McCartney |
Bug Description
Follow up on https:/
Ricardo is landing this without styling on the form field error, so this error still needs to be styled.
Related branches
lp://qastaging/~ricgard/maas/error-messages
- MAAS Maintainers: Pending requested
-
Diff: 127 lines (+55/-20) (has conflicts)4 files modifiedsrc/maasserver/static/css/maas-styles.css (+4/-0)
src/maasserver/static/partials/node-details.html (+21/-19)
src/maasserver/static/scss/maas/components/_forms.scss (+29/-0)
src/maasserver/static/scss/maas/components/_placeholders.scss (+1/-1)
lp://qastaging/~rbanffy/maas/bug-1454355-add-extra-nic-styling
- Blake Rouse (community): Approve
-
Diff: 198 lines (+106/-21)6 files modifiedsrc/maasserver/static/css/maas-styles.css (+1/-1)
src/maasserver/static/js/angular/controllers/node_details.js (+10/-0)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+44/-0)
src/maasserver/static/partials/node-details.html (+21/-19)
src/maasserver/static/scss/maas/components/_forms.scss (+29/-0)
src/maasserver/static/scss/maas/components/_placeholders.scss (+1/-1)
Changed in maas: | |
status: | New → In Progress |
importance: | Undecided → High |
milestone: | none → 1.8.0 |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The error is defined in lines 290-291 of src/maasserver/ static/ partials/ node-details. html (line numbers can vary depending on merges). The span with the error message is as follows:
<span class="three-col maas-dbl-overlay" data-ng- show="nic. errormsg" >{$ nic.errormsg $}</span>
Adding a new class to the class attribute of the span tag may be the best approach. Feel free to move it around (if you want it to be on the right of the input, for instance) a bit. If the data-ng-show attribute is kept intact, the app should continue working as expected.