1.8b4 add extra NIC styling

Bug #1454355 reported by Carla Berkers
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Richard McCartney

Bug Description

Follow up on https://bugs.launchpad.net/maas/+bug/1438842.

Ricardo is landing this without styling on the form field error, so this error still needs to be styled.

Tags: ui

Related branches

Revision history for this message
Ricardo Bánffy (rbanffy) wrote :

The error is defined in lines 290-291 of src/maasserver/static/partials/node-details.html (line numbers can vary depending on merges). The span with the error message is as follows:

<span class="three-col maas-dbl-overlay" data-ng-show="nic.errormsg">{$ nic.errormsg $}</span>

Adding a new class to the class attribute of the span tag may be the best approach. Feel free to move it around (if you want it to be on the right of the input, for instance) a bit. If the data-ng-show attribute is kept intact, the app should continue working as expected.

Revision history for this message
Richard McCartney (ricgard) wrote :

Hey Ricardo,

I've created a new style based on what the design team have given me. This form style now adds a error class .error on the inline to style the whole box area to say its incorrect and then the error message span.

<div class="inline error">
    <label for="test">Test label</label>
    <input type="text"></input>
    <span class="error-message">Input error message</span>
</div>

Above is the markup which it effects I have attached my branch to this bug as it also will be a global style for error messages. Is this something we can change easily?

Rich

Changed in maas:
status: New → In Progress
importance: Undecided → High
milestone: none → 1.8.0
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.